You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2010/01/18 22:00:54 UTC
[jira] Created: (FELIX-1993) Enhance configuration printer support
Enhance configuration printer support
-------------------------------------
Key: FELIX-1993
URL: https://issues.apache.org/jira/browse/FELIX-1993
Project: Felix
Issue Type: Improvement
Components: Web Console
Affects Versions: webconsole-2.0.4
Reporter: Carsten Ziegeler
Currently I see three possible enhancements for the configuration printer:
1. Allow configuration printers without requiring the web console api - we already have this for plugin that can be plain servlets. It would be nice if we could do the same for configuration printers as well.
The problem here is which interface to use. The servlet interface could be used but at the same time, this interface requires request and response objects while the configuration printer should only write stuff - nothing else.
The title could just be a registration property.
2. Distinguish between configuration printers which display content in the web console, printers which just add stuff to the zip/download, and printers doing both. Current a configuration printer is always displayed in the web console and always included in the zip/download. There are use cases (like a printer for log files where the consoel shows only the recent log file and the zip contains all rotated files) for having printers for just the download and I guess having printers for just the console could make sense as well.
An alternative would be to pass a mode into the configuration printer like MODE_DISPLAY and MODE_DOWNLOAD.
3. I'm not sure about this one but it came to my mind while thinking about 2.
What about allowing a configuration printer to add a file to the download zip instead of just providing text? For example the printer could just add all log files instead of reading them and making a long text. For example if you have a log file with log rotation and there are already 15 log files. It would make sense to have all 15 files as separate files in the zip together with usefull names. But usually only one conifguration printer would do this.
We could imagine other stuff like adding graphics to the download etc. - but maybe we should think about this if we really need it :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1993) Enhance configuration printer
support
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805830#action_12805830 ]
Carsten Ziegeler commented on FELIX-1993:
-----------------------------------------
In revision 903993 I replaced the BinaryConfigurationPrinter with an AttachmentProvider which just returns an array of URLs for a given mode.
This makes the interaction easier (just a single method call) and reuses existing stuff (URLs)
> Enhance configuration printer support
> -------------------------------------
>
> Key: FELIX-1993
> URL: https://issues.apache.org/jira/browse/FELIX-1993
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-2.0.4
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: webconsole-3.0.0
>
> Attachments: configprinter.patch
>
>
> Currently I see three possible enhancements for the configuration printer:
> 1. Allow configuration printers without requiring the web console api - we already have this for plugin that can be plain servlets. It would be nice if we could do the same for configuration printers as well.
> The problem here is which interface to use. The servlet interface could be used but at the same time, this interface requires request and response objects while the configuration printer should only write stuff - nothing else.
> The title could just be a registration property.
> 2. Distinguish between configuration printers which display content in the web console, printers which just add stuff to the zip/download, and printers doing both. Current a configuration printer is always displayed in the web console and always included in the zip/download. There are use cases (like a printer for log files where the consoel shows only the recent log file and the zip contains all rotated files) for having printers for just the download and I guess having printers for just the console could make sense as well.
> An alternative would be to pass a mode into the configuration printer like MODE_DISPLAY and MODE_DOWNLOAD.
> 3. I'm not sure about this one but it came to my mind while thinking about 2.
> What about allowing a configuration printer to add a file to the download zip instead of just providing text? For example the printer could just add all log files instead of reading them and making a long text. For example if you have a log file with log rotation and there are already 15 log files. It would make sense to have all 15 files as separate files in the zip together with usefull names. But usually only one conifguration printer would do this.
> We could imagine other stuff like adding graphics to the download etc. - but maybe we should think about this if we really need it :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1993) Enhance configuration printer
support
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803456#action_12803456 ]
Carsten Ziegeler commented on FELIX-1993:
-----------------------------------------
> Line 38 should probably read:
> String MODE_TXT = "txt" (was: String MODE_TXT = "zip")
Upps, yes - thanks :)
I'll commit the patch tomorrow
Re 1.
Yes I guess it's not worth the effort to find an interface for this without relying on the web console api, so let's forget about it for now.
Re 3.
I thought about adding an ExtendedConfigurationPrinter interface - we can't change the ConfigurationPrinter interface as this would break compatibility. I'll think about this a little bit more and come up with a patch.
> Enhance configuration printer support
> -------------------------------------
>
> Key: FELIX-1993
> URL: https://issues.apache.org/jira/browse/FELIX-1993
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-2.0.4
> Reporter: Carsten Ziegeler
> Attachments: configprinter.patch
>
>
> Currently I see three possible enhancements for the configuration printer:
> 1. Allow configuration printers without requiring the web console api - we already have this for plugin that can be plain servlets. It would be nice if we could do the same for configuration printers as well.
> The problem here is which interface to use. The servlet interface could be used but at the same time, this interface requires request and response objects while the configuration printer should only write stuff - nothing else.
> The title could just be a registration property.
> 2. Distinguish between configuration printers which display content in the web console, printers which just add stuff to the zip/download, and printers doing both. Current a configuration printer is always displayed in the web console and always included in the zip/download. There are use cases (like a printer for log files where the consoel shows only the recent log file and the zip contains all rotated files) for having printers for just the download and I guess having printers for just the console could make sense as well.
> An alternative would be to pass a mode into the configuration printer like MODE_DISPLAY and MODE_DOWNLOAD.
> 3. I'm not sure about this one but it came to my mind while thinking about 2.
> What about allowing a configuration printer to add a file to the download zip instead of just providing text? For example the printer could just add all log files instead of reading them and making a long text. For example if you have a log file with log rotation and there are already 15 log files. It would make sense to have all 15 files as separate files in the zip together with usefull names. But usually only one conifguration printer would do this.
> We could imagine other stuff like adding graphics to the download etc. - but maybe we should think about this if we really need it :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-1993) Enhance configuration printer support
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler closed FELIX-1993.
-----------------------------------
> Enhance configuration printer support
> -------------------------------------
>
> Key: FELIX-1993
> URL: https://issues.apache.org/jira/browse/FELIX-1993
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-2.0.4
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: webconsole-3.0.0
>
> Attachments: configprinter.patch
>
>
> Currently I see three possible enhancements for the configuration printer:
> 1. Allow configuration printers without requiring the web console api - we already have this for plugin that can be plain servlets. It would be nice if we could do the same for configuration printers as well.
> The problem here is which interface to use. The servlet interface could be used but at the same time, this interface requires request and response objects while the configuration printer should only write stuff - nothing else.
> The title could just be a registration property.
> 2. Distinguish between configuration printers which display content in the web console, printers which just add stuff to the zip/download, and printers doing both. Current a configuration printer is always displayed in the web console and always included in the zip/download. There are use cases (like a printer for log files where the consoel shows only the recent log file and the zip contains all rotated files) for having printers for just the download and I guess having printers for just the console could make sense as well.
> An alternative would be to pass a mode into the configuration printer like MODE_DISPLAY and MODE_DOWNLOAD.
> 3. I'm not sure about this one but it came to my mind while thinking about 2.
> What about allowing a configuration printer to add a file to the download zip instead of just providing text? For example the printer could just add all log files instead of reading them and making a long text. For example if you have a log file with log rotation and there are already 15 log files. It would make sense to have all 15 files as separate files in the zip together with usefull names. But usually only one conifguration printer would do this.
> We could imagine other stuff like adding graphics to the download etc. - but maybe we should think about this if we really need it :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-1993) Enhance configuration printer support
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler resolved FELIX-1993.
-------------------------------------
Resolution: Fixed
> Enhance configuration printer support
> -------------------------------------
>
> Key: FELIX-1993
> URL: https://issues.apache.org/jira/browse/FELIX-1993
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-2.0.4
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: webconsole-3.0.0
>
> Attachments: configprinter.patch
>
>
> Currently I see three possible enhancements for the configuration printer:
> 1. Allow configuration printers without requiring the web console api - we already have this for plugin that can be plain servlets. It would be nice if we could do the same for configuration printers as well.
> The problem here is which interface to use. The servlet interface could be used but at the same time, this interface requires request and response objects while the configuration printer should only write stuff - nothing else.
> The title could just be a registration property.
> 2. Distinguish between configuration printers which display content in the web console, printers which just add stuff to the zip/download, and printers doing both. Current a configuration printer is always displayed in the web console and always included in the zip/download. There are use cases (like a printer for log files where the consoel shows only the recent log file and the zip contains all rotated files) for having printers for just the download and I guess having printers for just the console could make sense as well.
> An alternative would be to pass a mode into the configuration printer like MODE_DISPLAY and MODE_DOWNLOAD.
> 3. I'm not sure about this one but it came to my mind while thinking about 2.
> What about allowing a configuration printer to add a file to the download zip instead of just providing text? For example the printer could just add all log files instead of reading them and making a long text. For example if you have a log file with log rotation and there are already 15 log files. It would make sense to have all 15 files as separate files in the zip together with usefull names. But usually only one conifguration printer would do this.
> We could imagine other stuff like adding graphics to the download etc. - but maybe we should think about this if we really need it :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FELIX-1993) Enhance configuration printer support
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler reassigned FELIX-1993:
---------------------------------------
Assignee: Carsten Ziegeler
> Enhance configuration printer support
> -------------------------------------
>
> Key: FELIX-1993
> URL: https://issues.apache.org/jira/browse/FELIX-1993
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-2.0.4
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: webconsole-3.0.0
>
> Attachments: configprinter.patch
>
>
> Currently I see three possible enhancements for the configuration printer:
> 1. Allow configuration printers without requiring the web console api - we already have this for plugin that can be plain servlets. It would be nice if we could do the same for configuration printers as well.
> The problem here is which interface to use. The servlet interface could be used but at the same time, this interface requires request and response objects while the configuration printer should only write stuff - nothing else.
> The title could just be a registration property.
> 2. Distinguish between configuration printers which display content in the web console, printers which just add stuff to the zip/download, and printers doing both. Current a configuration printer is always displayed in the web console and always included in the zip/download. There are use cases (like a printer for log files where the consoel shows only the recent log file and the zip contains all rotated files) for having printers for just the download and I guess having printers for just the console could make sense as well.
> An alternative would be to pass a mode into the configuration printer like MODE_DISPLAY and MODE_DOWNLOAD.
> 3. I'm not sure about this one but it came to my mind while thinking about 2.
> What about allowing a configuration printer to add a file to the download zip instead of just providing text? For example the printer could just add all log files instead of reading them and making a long text. For example if you have a log file with log rotation and there are already 15 log files. It would make sense to have all 15 files as separate files in the zip together with usefull names. But usually only one conifguration printer would do this.
> We could imagine other stuff like adding graphics to the download etc. - but maybe we should think about this if we really need it :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (FELIX-1993) Enhance configuration printer support
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler reopened FELIX-1993:
-------------------------------------
> Enhance configuration printer support
> -------------------------------------
>
> Key: FELIX-1993
> URL: https://issues.apache.org/jira/browse/FELIX-1993
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-2.0.4
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: webconsole-3.0.0
>
> Attachments: configprinter.patch
>
>
> Currently I see three possible enhancements for the configuration printer:
> 1. Allow configuration printers without requiring the web console api - we already have this for plugin that can be plain servlets. It would be nice if we could do the same for configuration printers as well.
> The problem here is which interface to use. The servlet interface could be used but at the same time, this interface requires request and response objects while the configuration printer should only write stuff - nothing else.
> The title could just be a registration property.
> 2. Distinguish between configuration printers which display content in the web console, printers which just add stuff to the zip/download, and printers doing both. Current a configuration printer is always displayed in the web console and always included in the zip/download. There are use cases (like a printer for log files where the consoel shows only the recent log file and the zip contains all rotated files) for having printers for just the download and I guess having printers for just the console could make sense as well.
> An alternative would be to pass a mode into the configuration printer like MODE_DISPLAY and MODE_DOWNLOAD.
> 3. I'm not sure about this one but it came to my mind while thinking about 2.
> What about allowing a configuration printer to add a file to the download zip instead of just providing text? For example the printer could just add all log files instead of reading them and making a long text. For example if you have a log file with log rotation and there are already 15 log files. It would make sense to have all 15 files as separate files in the zip together with usefull names. But usually only one conifguration printer would do this.
> We could imagine other stuff like adding graphics to the download etc. - but maybe we should think about this if we really need it :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-1993) Enhance configuration printer support
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler closed FELIX-1993.
-----------------------------------
Resolution: Fixed
I think we now have all important enhancements implemented.
> Enhance configuration printer support
> -------------------------------------
>
> Key: FELIX-1993
> URL: https://issues.apache.org/jira/browse/FELIX-1993
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-2.0.4
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: webconsole-3.0.0
>
> Attachments: configprinter.patch
>
>
> Currently I see three possible enhancements for the configuration printer:
> 1. Allow configuration printers without requiring the web console api - we already have this for plugin that can be plain servlets. It would be nice if we could do the same for configuration printers as well.
> The problem here is which interface to use. The servlet interface could be used but at the same time, this interface requires request and response objects while the configuration printer should only write stuff - nothing else.
> The title could just be a registration property.
> 2. Distinguish between configuration printers which display content in the web console, printers which just add stuff to the zip/download, and printers doing both. Current a configuration printer is always displayed in the web console and always included in the zip/download. There are use cases (like a printer for log files where the consoel shows only the recent log file and the zip contains all rotated files) for having printers for just the download and I guess having printers for just the console could make sense as well.
> An alternative would be to pass a mode into the configuration printer like MODE_DISPLAY and MODE_DOWNLOAD.
> 3. I'm not sure about this one but it came to my mind while thinking about 2.
> What about allowing a configuration printer to add a file to the download zip instead of just providing text? For example the printer could just add all log files instead of reading them and making a long text. For example if you have a log file with log rotation and there are already 15 log files. It would make sense to have all 15 files as separate files in the zip together with usefull names. But usually only one conifguration printer would do this.
> We could imagine other stuff like adding graphics to the download etc. - but maybe we should think about this if we really need it :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1993) Enhance configuration printer
support
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805525#action_12805525 ]
Carsten Ziegeler commented on FELIX-1993:
-----------------------------------------
I've added another optional interface BinaryConfigurationProvider in revision: 903666.
This is a POC for 3. - a configuration printer can now implement this interface and add a set of files to the downloadable zip. This interface is currently only used in the zip mode - however it would be possible to use it in html mode as well - like showing an image in the console etc.
> Enhance configuration printer support
> -------------------------------------
>
> Key: FELIX-1993
> URL: https://issues.apache.org/jira/browse/FELIX-1993
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-2.0.4
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: webconsole-3.0.0
>
> Attachments: configprinter.patch
>
>
> Currently I see three possible enhancements for the configuration printer:
> 1. Allow configuration printers without requiring the web console api - we already have this for plugin that can be plain servlets. It would be nice if we could do the same for configuration printers as well.
> The problem here is which interface to use. The servlet interface could be used but at the same time, this interface requires request and response objects while the configuration printer should only write stuff - nothing else.
> The title could just be a registration property.
> 2. Distinguish between configuration printers which display content in the web console, printers which just add stuff to the zip/download, and printers doing both. Current a configuration printer is always displayed in the web console and always included in the zip/download. There are use cases (like a printer for log files where the consoel shows only the recent log file and the zip contains all rotated files) for having printers for just the download and I guess having printers for just the console could make sense as well.
> An alternative would be to pass a mode into the configuration printer like MODE_DISPLAY and MODE_DOWNLOAD.
> 3. I'm not sure about this one but it came to my mind while thinking about 2.
> What about allowing a configuration printer to add a file to the download zip instead of just providing text? For example the printer could just add all log files instead of reading them and making a long text. For example if you have a log file with log rotation and there are already 15 log files. It would make sense to have all 15 files as separate files in the zip together with usefull names. But usually only one conifguration printer would do this.
> We could imagine other stuff like adding graphics to the download etc. - but maybe we should think about this if we really need it :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1993) Enhance configuration printer
support
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803340#action_12803340 ]
Felix Meschberger commented on FELIX-1993:
------------------------------------------
Re 1. (Configuration Printer without WebConsole API)
This would be nice .. but I fear, we will not find a solution.
Re 3. (Adding Files)
That would be an interesting addition, mainly for the ZIP file case. Maybe an optional method to be called on the ConfigurationPrinter in mode ZIP. The method could either be part of the Configuration Printer API or be found by reflection dynamically.
> Enhance configuration printer support
> -------------------------------------
>
> Key: FELIX-1993
> URL: https://issues.apache.org/jira/browse/FELIX-1993
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-2.0.4
> Reporter: Carsten Ziegeler
> Attachments: configprinter.patch
>
>
> Currently I see three possible enhancements for the configuration printer:
> 1. Allow configuration printers without requiring the web console api - we already have this for plugin that can be plain servlets. It would be nice if we could do the same for configuration printers as well.
> The problem here is which interface to use. The servlet interface could be used but at the same time, this interface requires request and response objects while the configuration printer should only write stuff - nothing else.
> The title could just be a registration property.
> 2. Distinguish between configuration printers which display content in the web console, printers which just add stuff to the zip/download, and printers doing both. Current a configuration printer is always displayed in the web console and always included in the zip/download. There are use cases (like a printer for log files where the consoel shows only the recent log file and the zip contains all rotated files) for having printers for just the download and I guess having printers for just the console could make sense as well.
> An alternative would be to pass a mode into the configuration printer like MODE_DISPLAY and MODE_DOWNLOAD.
> 3. I'm not sure about this one but it came to my mind while thinking about 2.
> What about allowing a configuration printer to add a file to the download zip instead of just providing text? For example the printer could just add all log files instead of reading them and making a long text. For example if you have a log file with log rotation and there are already 15 log files. It would make sense to have all 15 files as separate files in the zip together with usefull names. But usually only one conifguration printer would do this.
> We could imagine other stuff like adding graphics to the download etc. - but maybe we should think about this if we really need it :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1993) Enhance configuration printer support
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler updated FELIX-1993:
------------------------------------
Attachment: configprinter.patch
Proposed solution for handling different modes for configuration printers
> Enhance configuration printer support
> -------------------------------------
>
> Key: FELIX-1993
> URL: https://issues.apache.org/jira/browse/FELIX-1993
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-2.0.4
> Reporter: Carsten Ziegeler
> Attachments: configprinter.patch
>
>
> Currently I see three possible enhancements for the configuration printer:
> 1. Allow configuration printers without requiring the web console api - we already have this for plugin that can be plain servlets. It would be nice if we could do the same for configuration printers as well.
> The problem here is which interface to use. The servlet interface could be used but at the same time, this interface requires request and response objects while the configuration printer should only write stuff - nothing else.
> The title could just be a registration property.
> 2. Distinguish between configuration printers which display content in the web console, printers which just add stuff to the zip/download, and printers doing both. Current a configuration printer is always displayed in the web console and always included in the zip/download. There are use cases (like a printer for log files where the consoel shows only the recent log file and the zip contains all rotated files) for having printers for just the download and I guess having printers for just the console could make sense as well.
> An alternative would be to pass a mode into the configuration printer like MODE_DISPLAY and MODE_DOWNLOAD.
> 3. I'm not sure about this one but it came to my mind while thinking about 2.
> What about allowing a configuration printer to add a file to the download zip instead of just providing text? For example the printer could just add all log files instead of reading them and making a long text. For example if you have a log file with log rotation and there are already 15 log files. It would make sense to have all 15 files as separate files in the zip together with usefull names. But usually only one conifguration printer would do this.
> We could imagine other stuff like adding graphics to the download etc. - but maybe we should think about this if we really need it :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1993) Enhance configuration printer
support
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805848#action_12805848 ]
Carsten Ziegeler commented on FELIX-1993:
-----------------------------------------
Cleaned up the code in revision 904008 a little bit and moved the attachment handling into the configuration printer
> Enhance configuration printer support
> -------------------------------------
>
> Key: FELIX-1993
> URL: https://issues.apache.org/jira/browse/FELIX-1993
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-2.0.4
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: webconsole-3.0.0
>
> Attachments: configprinter.patch
>
>
> Currently I see three possible enhancements for the configuration printer:
> 1. Allow configuration printers without requiring the web console api - we already have this for plugin that can be plain servlets. It would be nice if we could do the same for configuration printers as well.
> The problem here is which interface to use. The servlet interface could be used but at the same time, this interface requires request and response objects while the configuration printer should only write stuff - nothing else.
> The title could just be a registration property.
> 2. Distinguish between configuration printers which display content in the web console, printers which just add stuff to the zip/download, and printers doing both. Current a configuration printer is always displayed in the web console and always included in the zip/download. There are use cases (like a printer for log files where the consoel shows only the recent log file and the zip contains all rotated files) for having printers for just the download and I guess having printers for just the console could make sense as well.
> An alternative would be to pass a mode into the configuration printer like MODE_DISPLAY and MODE_DOWNLOAD.
> 3. I'm not sure about this one but it came to my mind while thinking about 2.
> What about allowing a configuration printer to add a file to the download zip instead of just providing text? For example the printer could just add all log files instead of reading them and making a long text. For example if you have a log file with log rotation and there are already 15 log files. It would make sense to have all 15 files as separate files in the zip together with usefull names. But usually only one conifguration printer would do this.
> We could imagine other stuff like adding graphics to the download etc. - but maybe we should think about this if we really need it :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (FELIX-1993) Enhance configuration
printer support
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803340#action_12803340 ]
Felix Meschberger edited comment on FELIX-1993 at 1/21/10 3:54 PM:
-------------------------------------------------------------------
Re 1. (Configuration Printer without WebConsole API)
This would be nice .. but I fear, we will not find a solution.
Re 3. (Adding Files)
That would be an interesting addition, mainly for the ZIP file case. Maybe an optional method to be called on the ConfigurationPrinter in mode ZIP. The method could either be part of the Configuration Printer API or be found by reflection dynamically.
Any files could be placed in a sub-folder named after the title of the ConfigurationPrinter providing the files.
was (Author: fmeschbe):
Re 1. (Configuration Printer without WebConsole API)
This would be nice .. but I fear, we will not find a solution.
Re 3. (Adding Files)
That would be an interesting addition, mainly for the ZIP file case. Maybe an optional method to be called on the ConfigurationPrinter in mode ZIP. The method could either be part of the Configuration Printer API or be found by reflection dynamically.
> Enhance configuration printer support
> -------------------------------------
>
> Key: FELIX-1993
> URL: https://issues.apache.org/jira/browse/FELIX-1993
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-2.0.4
> Reporter: Carsten Ziegeler
> Attachments: configprinter.patch
>
>
> Currently I see three possible enhancements for the configuration printer:
> 1. Allow configuration printers without requiring the web console api - we already have this for plugin that can be plain servlets. It would be nice if we could do the same for configuration printers as well.
> The problem here is which interface to use. The servlet interface could be used but at the same time, this interface requires request and response objects while the configuration printer should only write stuff - nothing else.
> The title could just be a registration property.
> 2. Distinguish between configuration printers which display content in the web console, printers which just add stuff to the zip/download, and printers doing both. Current a configuration printer is always displayed in the web console and always included in the zip/download. There are use cases (like a printer for log files where the consoel shows only the recent log file and the zip contains all rotated files) for having printers for just the download and I guess having printers for just the console could make sense as well.
> An alternative would be to pass a mode into the configuration printer like MODE_DISPLAY and MODE_DOWNLOAD.
> 3. I'm not sure about this one but it came to my mind while thinking about 2.
> What about allowing a configuration printer to add a file to the download zip instead of just providing text? For example the printer could just add all log files instead of reading them and making a long text. For example if you have a log file with log rotation and there are already 15 log files. It would make sense to have all 15 files as separate files in the zip together with usefull names. But usually only one conifguration printer would do this.
> We could imagine other stuff like adding graphics to the download etc. - but maybe we should think about this if we really need it :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1993) Enhance configuration printer support
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler updated FELIX-1993:
------------------------------------
Fix Version/s: webconsole-3.0.0
> Enhance configuration printer support
> -------------------------------------
>
> Key: FELIX-1993
> URL: https://issues.apache.org/jira/browse/FELIX-1993
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-2.0.4
> Reporter: Carsten Ziegeler
> Fix For: webconsole-3.0.0
>
> Attachments: configprinter.patch
>
>
> Currently I see three possible enhancements for the configuration printer:
> 1. Allow configuration printers without requiring the web console api - we already have this for plugin that can be plain servlets. It would be nice if we could do the same for configuration printers as well.
> The problem here is which interface to use. The servlet interface could be used but at the same time, this interface requires request and response objects while the configuration printer should only write stuff - nothing else.
> The title could just be a registration property.
> 2. Distinguish between configuration printers which display content in the web console, printers which just add stuff to the zip/download, and printers doing both. Current a configuration printer is always displayed in the web console and always included in the zip/download. There are use cases (like a printer for log files where the consoel shows only the recent log file and the zip contains all rotated files) for having printers for just the download and I guess having printers for just the console could make sense as well.
> An alternative would be to pass a mode into the configuration printer like MODE_DISPLAY and MODE_DOWNLOAD.
> 3. I'm not sure about this one but it came to my mind while thinking about 2.
> What about allowing a configuration printer to add a file to the download zip instead of just providing text? For example the printer could just add all log files instead of reading them and making a long text. For example if you have a log file with log rotation and there are already 15 log files. It would make sense to have all 15 files as separate files in the zip together with usefull names. But usually only one conifguration printer would do this.
> We could imagine other stuff like adding graphics to the download etc. - but maybe we should think about this if we really need it :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1993) Enhance configuration printer
support
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803688#action_12803688 ]
Carsten Ziegeler commented on FELIX-1993:
-----------------------------------------
I've appled the (fixed) patch for mode support in the configuration printers in revision 902075
> Enhance configuration printer support
> -------------------------------------
>
> Key: FELIX-1993
> URL: https://issues.apache.org/jira/browse/FELIX-1993
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-2.0.4
> Reporter: Carsten Ziegeler
> Attachments: configprinter.patch
>
>
> Currently I see three possible enhancements for the configuration printer:
> 1. Allow configuration printers without requiring the web console api - we already have this for plugin that can be plain servlets. It would be nice if we could do the same for configuration printers as well.
> The problem here is which interface to use. The servlet interface could be used but at the same time, this interface requires request and response objects while the configuration printer should only write stuff - nothing else.
> The title could just be a registration property.
> 2. Distinguish between configuration printers which display content in the web console, printers which just add stuff to the zip/download, and printers doing both. Current a configuration printer is always displayed in the web console and always included in the zip/download. There are use cases (like a printer for log files where the consoel shows only the recent log file and the zip contains all rotated files) for having printers for just the download and I guess having printers for just the console could make sense as well.
> An alternative would be to pass a mode into the configuration printer like MODE_DISPLAY and MODE_DOWNLOAD.
> 3. I'm not sure about this one but it came to my mind while thinking about 2.
> What about allowing a configuration printer to add a file to the download zip instead of just providing text? For example the printer could just add all log files instead of reading them and making a long text. For example if you have a log file with log rotation and there are already 15 log files. It would make sense to have all 15 files as separate files in the zip together with usefull names. But usually only one conifguration printer would do this.
> We could imagine other stuff like adding graphics to the download etc. - but maybe we should think about this if we really need it :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1993) Enhance configuration printer
support
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803339#action_12803339 ]
Felix Meschberger commented on FELIX-1993:
------------------------------------------
Patch looks fine.
Line 38 should probably read:
String MODE_TXT = "txt" (was: String MODE_TXT = "zip")
> Enhance configuration printer support
> -------------------------------------
>
> Key: FELIX-1993
> URL: https://issues.apache.org/jira/browse/FELIX-1993
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-2.0.4
> Reporter: Carsten Ziegeler
> Attachments: configprinter.patch
>
>
> Currently I see three possible enhancements for the configuration printer:
> 1. Allow configuration printers without requiring the web console api - we already have this for plugin that can be plain servlets. It would be nice if we could do the same for configuration printers as well.
> The problem here is which interface to use. The servlet interface could be used but at the same time, this interface requires request and response objects while the configuration printer should only write stuff - nothing else.
> The title could just be a registration property.
> 2. Distinguish between configuration printers which display content in the web console, printers which just add stuff to the zip/download, and printers doing both. Current a configuration printer is always displayed in the web console and always included in the zip/download. There are use cases (like a printer for log files where the consoel shows only the recent log file and the zip contains all rotated files) for having printers for just the download and I guess having printers for just the console could make sense as well.
> An alternative would be to pass a mode into the configuration printer like MODE_DISPLAY and MODE_DOWNLOAD.
> 3. I'm not sure about this one but it came to my mind while thinking about 2.
> What about allowing a configuration printer to add a file to the download zip instead of just providing text? For example the printer could just add all log files instead of reading them and making a long text. For example if you have a log file with log rotation and there are already 15 log files. It would make sense to have all 15 files as separate files in the zip together with usefull names. But usually only one conifguration printer would do this.
> We could imagine other stuff like adding graphics to the download etc. - but maybe we should think about this if we really need it :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1993) Enhance configuration printer
support
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805466#action_12805466 ]
Carsten Ziegeler commented on FELIX-1993:
-----------------------------------------
Added a ModeAwareConfigurationPrinter interface in revision 903602 - this allows a printer to output different things depending on the used mode.
> Enhance configuration printer support
> -------------------------------------
>
> Key: FELIX-1993
> URL: https://issues.apache.org/jira/browse/FELIX-1993
> Project: Felix
> Issue Type: Improvement
> Components: Web Console
> Affects Versions: webconsole-2.0.4
> Reporter: Carsten Ziegeler
> Attachments: configprinter.patch
>
>
> Currently I see three possible enhancements for the configuration printer:
> 1. Allow configuration printers without requiring the web console api - we already have this for plugin that can be plain servlets. It would be nice if we could do the same for configuration printers as well.
> The problem here is which interface to use. The servlet interface could be used but at the same time, this interface requires request and response objects while the configuration printer should only write stuff - nothing else.
> The title could just be a registration property.
> 2. Distinguish between configuration printers which display content in the web console, printers which just add stuff to the zip/download, and printers doing both. Current a configuration printer is always displayed in the web console and always included in the zip/download. There are use cases (like a printer for log files where the consoel shows only the recent log file and the zip contains all rotated files) for having printers for just the download and I guess having printers for just the console could make sense as well.
> An alternative would be to pass a mode into the configuration printer like MODE_DISPLAY and MODE_DOWNLOAD.
> 3. I'm not sure about this one but it came to my mind while thinking about 2.
> What about allowing a configuration printer to add a file to the download zip instead of just providing text? For example the printer could just add all log files instead of reading them and making a long text. For example if you have a log file with log rotation and there are already 15 log files. It would make sense to have all 15 files as separate files in the zip together with usefull names. But usually only one conifguration printer would do this.
> We could imagine other stuff like adding graphics to the download etc. - but maybe we should think about this if we really need it :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.