[GitHub] [solr] cpoerschke commented on a change in pull request #198: SOLR-15124 Remove container level admin handlers from ImplicitPlugins.json

[GitBox <gi...@apache.org>]

cpoerschke commented on a change in pull request #198:
URL: https://github.com/apache/solr/pull/198#discussion_r663209951



##########
File path: solr/core/src/java/org/apache/solr/handler/admin/LoggingHandler.java
##########
@@ -47,23 +47,16 @@
 public class LoggingHandler extends RequestHandlerBase implements SolrCoreAware {

Review comment:
       ```suggestion
   public class LoggingHandler extends RequestHandlerBase {
   ```
   
   maybe since `inform(SolrCore core)` is becoming a no-op or comment w.r.t. why `inform` is needed albeit as a no-op.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org