You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/02 10:05:30 UTC

[GitHub] [arrow] jvanstraten commented on a diff in pull request #13468: ARROW-16816: [C++] Upgrade Substrait to v0.6.0

jvanstraten commented on code in PR #13468:
URL: https://github.com/apache/arrow/pull/13468#discussion_r912346149


##########
cpp/src/arrow/engine/substrait/serde_test.cc:
##########
@@ -185,7 +185,8 @@ TEST(Substrait, SupportedExtensionTypes) {
     ASSERT_OK_AND_ASSIGN(
         auto buf,
         internal::SubstraitFromJSON(
-            "Type", "{\"user_defined_type_reference\": " + std::to_string(anchor) + "}"));
+            "Type", "{\"user_defined\": { \"type_reference\": " + std::to_string(anchor) +
+                        ", \"nullability\": \"NULLABILITY_NULLABLE\" } }"));

Review Comment:
   No, Substrait itself didn't consider user-defined types to conceptually have nullability, for no particular reason I can think of. See https://github.com/substrait-io/substrait/pull/217



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org