You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by ameybarve15 <gi...@git.apache.org> on 2016/12/20 04:11:19 UTC
[GitHub] geode pull request #323: GEODE-1754: Cleaned up loadSharedConfigFromDir argu...
GitHub user ameybarve15 opened a pull request:
https://github.com/apache/geode/pull/323
GEODE-1754: Cleaned up loadSharedConfigFromDir argument from InternalLocator.startLocator and its associated code calls.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ameybarve15/incubator-geode feature/GEODE-1754
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/323.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #323
----
commit fee76f25f96bd01760880141ec642dba3097db1c
Author: Amey Barve <ab...@apache.org>
Date: 2016-12-19T09:17:55Z
GEODE-1754: Cleaned up loadSharedConfigFromDir argument from
InternalLocator.startLocator and its associated code calls.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #323: GEODE-1754: Cleaned up loadSharedConfigFromDir argu...
Posted by bschuchardt <gi...@git.apache.org>.
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/323#discussion_r93273525
--- Diff: geode-core/src/main/java/org/apache/geode/internal/DistributionLocator.java ---
@@ -166,9 +166,9 @@ public void run() {
try {
--- End diff --
There is also a static LOAD_SHARED_CONFIGURATION variable in this class that should be removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #323: GEODE-1754: Cleaned up loadSharedConfigFromDir argu...
Posted by ameybarve15 <gi...@git.apache.org>.
Github user ameybarve15 closed the pull request at:
https://github.com/apache/geode/pull/323
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #323: GEODE-1754: Cleaned up loadSharedConfigFromDir argument fr...
Posted by ameybarve15 <gi...@git.apache.org>.
Github user ameybarve15 commented on the issue:
https://github.com/apache/geode/pull/323
These changes have been merged in commit id: c33ce7db8148fe0b300066581f26582e3e044e96
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #323: GEODE-1754: Cleaned up loadSharedConfigFromDir argument fr...
Posted by bschuchardt <gi...@git.apache.org>.
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/323
Amey, if you don't mind I'm going to merge your commit with my fixes for GEODE-1893. I'm removing the peerLocator & serverLocator options for starting a locator and it's hitting the same code you've modified.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #323: GEODE-1754: Cleaned up loadSharedConfigFromDir argument fr...
Posted by ameybarve15 <gi...@git.apache.org>.
Github user ameybarve15 commented on the issue:
https://github.com/apache/geode/pull/323
These changes have been merged in commit id: c33ce7db8148fe0b300066581f26582e3e044e96
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #323: GEODE-1754: Cleaned up loadSharedConfigFromDir argu...
Posted by bschuchardt <gi...@git.apache.org>.
Github user bschuchardt commented on a diff in the pull request:
https://github.com/apache/geode/pull/323#discussion_r93273028
--- Diff: geode-core/src/main/java/org/apache/geode/distributed/Locator.java ---
@@ -253,7 +253,7 @@ private static Locator startLocator(int port, File logFile, InetAddress bindAddr
java.util.Properties dsProperties, boolean peerLocator, boolean serverLocator,
--- End diff --
Amey, there is also a loadSharedConfig static variable in Locator that should be removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---