You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "Hongten (via GitHub)" <gi...@apache.org> on 2023/02/23 06:27:53 UTC

[GitHub] [pulsar] Hongten commented on a diff in pull request #4604: Update logic for picking active consumer for failover subscription on non-partitioned topic.

Hongten commented on code in PR #4604:
URL: https://github.com/apache/pulsar/pull/4604#discussion_r1115280674


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractDispatcherSingleActiveConsumer.java:
##########
@@ -80,34 +80,45 @@ protected void notifyActiveConsumerChanged(Consumer activeConsumer) {
     }
 
     /**
-     * @return the previous active consumer if the consumer is changed, otherwise null.
+     * Pick active consumer for a topic for {@link SubType#Failover} subscription.
+     * If it's a non-partitioned topic then it'll pick consumer based on order they subscribe to the topic.
+     * If is's a partitioned topic, first sort consumers based on their priority level and consumer name then

Review Comment:
   Typo: `is's`, should be `it's`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org