You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "ppkarwasz (via GitHub)" <gi...@apache.org> on 2024/01/03 14:06:11 UTC
[PR] Port `log4j-slf4j-impl` changes from `2.x` (logging-log4j2)
ppkarwasz opened a new pull request, #2156:
URL: https://github.com/apache/logging-log4j2/pull/2156
This PR adds to the `log4j-slf4j-impl` module the missing changes from the `2.x` branch.
After this change `git diff 2.x main -- log4j-slf4j-impl` should only contain changes related to serialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Port `log4j-slf4j-impl` changes from `2.x` (logging-log4j2)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on code in PR #2156:
URL: https://github.com/apache/logging-log4j2/pull/2156#discussion_r1440589415
##########
log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/package-info.java:
##########
@@ -21,7 +21,7 @@
*/
@Export
@Header(name = Constants.BUNDLE_ACTIVATIONPOLICY, value = Constants.ACTIVATION_LAZY)
-@Version("2.21.0")
+@Version("2.23.0")
Review Comment:
@PascalSchumacher,
thanks for the remark.
We don't bump package versions automatically (if there are no minor/major changes we leave them the same, but in this case BND remarks that we have hidden (removed `public`) from two classes:
```
[ERROR] * org.apache.logging.slf4j PACKAGE MAJOR 2.23.0 2.21.0 3.0.0 -
[ERROR] MAJOR PACKAGE org.apache.logging.slf4j
...
[ERROR] MAJOR CLASS org.apache.logging.slf4j.Log4jLogger
[ERROR] REMOVED IMPLEMENTS java.io.Serializable
[ERROR] REMOVED CLASS org.apache.logging.slf4j.Log4jMarker
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Port `log4j-slf4j-impl` changes from `2.x` (logging-log4j2)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz merged PR #2156:
URL: https://github.com/apache/logging-log4j2/pull/2156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Port `log4j-slf4j-impl` changes from `2.x` (logging-log4j2)
Posted by "PascalSchumacher (via GitHub)" <gi...@apache.org>.
PascalSchumacher commented on code in PR #2156:
URL: https://github.com/apache/logging-log4j2/pull/2156#discussion_r1440510208
##########
log4j-slf4j-impl/src/main/java/org/apache/logging/slf4j/package-info.java:
##########
@@ -21,7 +21,7 @@
*/
@Export
@Header(name = Constants.BUNDLE_ACTIVATIONPOLICY, value = Constants.ACTIVATION_LAZY)
-@Version("2.21.0")
+@Version("2.23.0")
Review Comment:
I guess this should have a different value on `3.x` branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org