You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/11/11 14:47:14 UTC
[GitHub] [incubator-ratis] adoroszlai opened a new pull request #271: RATIS-1146. Does not build with newer JDK
adoroszlai opened a new pull request #271:
URL: https://github.com/apache/incubator-ratis/pull/271
## What changes were proposed in this pull request?
1. Add `javax.annotation-api` dependency, required for compilation with Java 9+.
2. Improve _compile_ CI check to build Ratis with both Java 8 and Java 11.
https://issues.apache.org/jira/browse/RATIS-1146
## How was this patch tested?
Compile checks:
https://github.com/adoroszlai/incubator-ratis/runs/1385567749#step:4:10
https://github.com/adoroszlai/incubator-ratis/runs/1385567774#step:4:1729
Compiled Ratis locally with the same Java versions, and Java 14, too:
```
$ mvn -DskipTests -V clean package
...
Java version: 14.0.1
...
[INFO] BUILD SUCCESS
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang merged pull request #271: RATIS-1146. Does not build with newer JDK
Posted by GitBox <gi...@apache.org>.
runzhiwang merged pull request #271:
URL: https://github.com/apache/incubator-ratis/pull/271
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang commented on pull request #271: RATIS-1146. Does not build with newer JDK
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #271:
URL: https://github.com/apache/incubator-ratis/pull/271#issuecomment-725869365
@adoroszlai Thanks the patch. @amaliujia Thanks for review. I have merged it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] adoroszlai commented on a change in pull request #271: RATIS-1146. Does not build with newer JDK
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #271:
URL: https://github.com/apache/incubator-ratis/pull/271#discussion_r521862273
##########
File path: .github/workflows/post-commit.yml
##########
@@ -19,9 +19,19 @@ jobs:
build:
name: compile
runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ java: [ 8, 11 ]
Review comment:
> is this the setup to have post commits runs build by java 11?
Correct.
> If so, is there a way to trigger the post commit in this PR so this change can be verified?
It was [already triggered](https://github.com/adoroszlai/incubator-ratis/runs/1385567774) in my own fork.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] amaliujia commented on a change in pull request #271: RATIS-1146. Does not build with newer JDK
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #271:
URL: https://github.com/apache/incubator-ratis/pull/271#discussion_r521649129
##########
File path: .github/workflows/post-commit.yml
##########
@@ -19,9 +19,19 @@ jobs:
build:
name: compile
runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ java: [ 8, 11 ]
Review comment:
Out of curiosity: is this the setup to have post commits runs build by java 11? If so, is there a way to trigger the post commit in this PR so this change can be verified?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] adoroszlai commented on pull request #271: RATIS-1146. Does not build with newer JDK
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #271:
URL: https://github.com/apache/incubator-ratis/pull/271#issuecomment-725883726
Thanks @amaliujia for the review, and @runzhiwang for reviewing and merging this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] amaliujia commented on a change in pull request #271: RATIS-1146. Does not build with newer JDK
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #271:
URL: https://github.com/apache/incubator-ratis/pull/271#discussion_r521865625
##########
File path: .github/workflows/post-commit.yml
##########
@@ -19,9 +19,19 @@ jobs:
build:
name: compile
runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ java: [ 8, 11 ]
Review comment:
Thank you for the clarification!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org