You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/23 09:10:27 UTC

[GitHub] [arrow] kszucs commented on a change in pull request #12494: ARROW-15760: [C++] Avoid hard dependency on git in cmake (download tarballs from github instead)

kszucs commented on a change in pull request #12494:
URL: https://github.com/apache/arrow/pull/12494#discussion_r812683871



##########
File path: cpp/src/arrow/engine/CMakeLists.txt
##########
@@ -48,8 +48,7 @@ set(SUBSTRAIT_PROTOS
     type_expressions)
 
 externalproject_add(substrait_ep
-                    GIT_REPOSITORY "${ARROW_SUBSTRAIT_REPO}"
-                    GIT_TAG "${ARROW_SUBSTRAIT_TAG}"
+                    URL "https://github.com/${ARROW_SUBSTRAIT_REPO}/archive/${ARROW_SUBSTRAIT_TAG}.tar.gz"

Review comment:
       This url will only work for github so we my want to restore the previous url and note that `ARROW_SUBSTRAIT_REPO` should be a github `user/repo` pair.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org