You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "stevomitric (via GitHub)" <gi...@apache.org> on 2026/09/07 14:50:21 UTC

[PR] [SPARK-59297][SQL][TESTS] Cover nanosecond precisions 7 and 8 in RowToColumnConverter round-trip tests [spark]

stevomitric opened a new pull request, #58575:
URL: https://github.com/apache/spark/pull/58575

   
   ### What changes were proposed in this pull request?
   
   Parameterize the `TimestampNTZNanosType` and `TimestampLTZNanosType` round-trip tests in `RowToColumnConverterSuite` over `Seq(7, 8, 9)` instead of only precision 9, mirroring the adjacent `TimeType column roundtrip` test. Test-only; no production change.
   
   ### Why are the changes needed?
   The row-to-column converter (vectorized execution / columnar projection) was only asserted at nanosecond precision 9, leaving precisions 7 and 8 unexercised.
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   `RowToColumnConverterSuite` passes at all three precisions; `sql/Test/scalastyle` is clean.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   Co-authored-by: Claude Code 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-59297][SQL][TESTS] Cover nanosecond precisions 7 and 8 in RowToColumnConverter round-trip tests [spark]

Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #58575:
URL: https://github.com/apache/spark/pull/58575#issuecomment-5583525115

   Thank you @stevomitric!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-59297][SQL][TESTS] Cover nanosecond precisions 7 and 8 in RowToColumnConverter round-trip tests [spark]

Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b closed pull request #58575: [SPARK-59297][SQL][TESTS] Cover nanosecond precisions 7 and 8 in RowToColumnConverter round-trip tests
URL: https://github.com/apache/spark/pull/58575


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-59297][SQL][TESTS] Cover nanosecond precisions 7 and 8 in RowToColumnConverter round-trip tests [spark]

Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #58575:
URL: https://github.com/apache/spark/pull/58575#issuecomment-5583540348

   **Merge Summary:**
   - merged into master https://github.com/apache/spark/commit/d26e1447b3e72cb1e9576c1d7c04f5e4f8edf49b
   - merged into branch-4.x https://github.com/apache/spark/commit/28d0e1460ac47a180264752c9dabade474f3b434
   
   *Posted by `merge_spark_pr.py`*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org