You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Konstantin Shvachko (JIRA)" <ji...@apache.org> on 2009/01/14 23:34:59 UTC
[jira] Commented: (HADOOP-5017) NameNode.namesystem should be
private
[ https://issues.apache.org/jira/browse/HADOOP-5017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663912#action_12663912 ]
Konstantin Shvachko commented on HADOOP-5017:
---------------------------------------------
I like the patch. Minor improvements:
- getNamesystem() need a JavaDoc comment not only the return value.
- Same in MiniDFSCluster.
Could you please additionally remove this warning:
- FileChecksumServlets redundant import of FSConstants
> NameNode.namesystem should be private
> -------------------------------------
>
> Key: HADOOP-5017
> URL: https://issues.apache.org/jira/browse/HADOOP-5017
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: 5017_20090112.patch
>
>
> As stated in the comment:
> {code}
> public FSNamesystem namesystem; // TODO: This should private. Use getNamesystem() instead.
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.