[GitHub] [superset] hughhhh commented on a change in pull request #17969: chore(dbc-ui): encode characters before building sqlalchemy uri

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #17969:
URL: https://github.com/apache/superset/pull/17969#discussion_r781401158



##########
File path: superset/databases/commands/validate.py
##########
@@ -99,9 +100,12 @@ def run(self) -> None:
         except json.decoder.JSONDecodeError:
             encrypted_extra = {}
 
+        # encode parameters
+        params = encode_parameters(self._properties.get("parameters", {}))

Review comment:
       encode paramaters returns the encode keys in a new dictionary (params) which is used to build the sqlalchemy url a few lines below




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org