[GitHub] [solr-sandbox] anshumg commented on a diff in pull request #32: Reindex Test, cover a few more test cases, additional config options.

[GitBox <gi...@apache.org>]

anshumg commented on code in PR #32:
URL: https://github.com/apache/solr-sandbox/pull/32#discussion_r935944295


##########
crossdc-consumer/src/main/java/org/apache/solr/crossdc/consumer/KafkaCrossDcConsumer.java:
##########
@@ -49,7 +49,7 @@ public KafkaCrossDcConsumer(KafkaCrossDcConf conf) {
 
     kafkaConsumerProp.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, conf.getBootStrapServers());
 
-    kafkaConsumerProp.put(ConsumerConfig.GROUP_ID_CONFIG, "group_1"); // TODO
+    kafkaConsumerProp.put(ConsumerConfig.GROUP_ID_CONFIG, conf.getGroupId()); // TODO

Review Comment:
   We can get rid of the `//TODO` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org