You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Dragos Schebesch via Review Board <no...@reviews.apache.org> on 2018/06/08 12:07:43 UTC

Review Request 67503: Added helper for fetching review id

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67503/
-----------------------------------------------------------

Review request for mesos and Andrew Schwartzmeyer.


Repository: mesos


Description
-------

Added helper for fetching review id


Diffs (updated)
-----

  support/python3/get-review-ids.py PRE-CREATION 


Diff: https://reviews.apache.org/r/67503/diff/1/


Testing
-------


Thanks,

Dragos Schebesch

Re: Review Request 67503: Added helper for fetching review id

Posted by Armand Grillet <ag...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67503/#review205905
-----------------------------------------------------------



The commit message should be edited to finish with a period and the Testing Done part should be filled even if it's just to say that tests have been done later in the chain.


support/python3/get-review-ids.py
Lines 19 (patched)
<https://reviews.apache.org/r/67503/#comment288803>

    Add a newline here, it's either:
    
    ```
    """Hello"""
    ```
    
    or
    
    ```
    """
    Lorem ipsum dolor sit amet, consectetur adipiscing elit.
    Etiam lectus orci, sodales a est in, vulputate egestas turpis. 
    Quisque quis rhoncus elit.
    """
    ```
    
    Also, s/`This file is used to get the`/`This script gets`.



support/python3/get-review-ids.py
Lines 30 (patched)
<https://reviews.apache.org/r/67503/#comment288804>

    Missing period.



support/python3/get-review-ids.py
Lines 41 (patched)
<https://reviews.apache.org/r/67503/#comment288805>

    Add a newline after the `""""`.



support/python3/get-review-ids.py
Lines 42 (patched)
<https://reviews.apache.org/r/67503/#comment288806>

    Missing period.



support/python3/get-review-ids.py
Lines 49 (patched)
<https://reviews.apache.org/r/67503/#comment288807>

    What happens if `--out-file` is not used?


- Armand Grillet


On June 14, 2018, 11:13 p.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67503/
> -----------------------------------------------------------
> 
> (Updated June 14, 2018, 11:13 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added helper for fetching review id
> 
> 
> Diffs
> -----
> 
>   support/python3/get-review-ids.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67503/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>

Re: Review Request 67503: Added support helper for fetching review ids.

Posted by Armand Grillet <ag...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67503/#review206382
-----------------------------------------------------------


Fix it, then Ship it!




LGTM except the first line. FYI the commit header and message should contain no line that are more than 72 characters.


support/python3/get-review-ids.py
Lines 1 (patched)
<https://reviews.apache.org/r/67503/#comment290026>

    Should be `python3`.


- Armand Grillet


On July 19, 2018, 3:48 p.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67503/
> -----------------------------------------------------------
> 
> (Updated July 19, 2018, 3:48 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added helper for fetching review id, which is needed to decouple this logic from verify-reviews.py. We need this for the windows build so we can trigger a downstream job for each review request on another server.
> 
> 
> Diffs
> -----
> 
>   support/python3/get-review-ids.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67503/diff/4/
> 
> 
> Testing
> -------
> 
> Sample run on this review request id:
> ```
> ./get-review-ids.py -r 67503
> Dependent review: https://reviews.apache.org/api/review-requests/67502/
> 67502
> 
> 67503
> ```
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>