[GitHub] [spark] TJX2014 commented on a change in pull request #29156: [SPARK-32347][SQL] Hint in CTE should be resolved in Hints batch rule

[GitBox <gi...@apache.org>]

TJX2014 commented on a change in pull request #29156:
URL: https://github.com/apache/spark/pull/29156#discussion_r456969527



##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
##########
@@ -2558,6 +2558,14 @@ abstract class SQLQuerySuiteBase extends QueryTest with SQLTestUtils with TestHi
       }
     }
   }
+
+  test("SPARK-32347: cte hint should be resolved in Hints batch rule") {
+    withTempView("t") {
+      sql("create temporary view t as select 1 as id")
+      sql("with cte as (select /*+ BROADCAST(id) */ id from t) select id from cte")

Review comment:
       Thank you, I need to check the hist, seems something wrong with the patch.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org