You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/08/06 05:15:28 UTC

[GitHub] [incubator-pinot] fx19880617 commented on pull request #5795: Support aggregation function name with underscore inside

fx19880617 commented on pull request #5795:
URL: https://github.com/apache/incubator-pinot/pull/5795#issuecomment-669699817


   > I think the current version works, but has some inefficiency.
   > Should we just change `ST_UNION` to `STUNION` and always remove underscore if exists? The logic will be much simpler. Sorry to go back and forth on this.
   
   I actually prefer to this way before we have two functions with same name after removing all "_" :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org