You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/01/11 14:50:48 UTC

[GitHub] [iotdb] HTHou commented on a change in pull request #2389: show devices limit

HTHou commented on a change in pull request #2389:
URL: https://github.com/apache/iotdb/pull/2389#discussion_r555099763



##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/sys/ShowPlan.java
##########
@@ -44,6 +65,34 @@ public ShowContentType getShowContentType() {
     return showContentType;
   }
 
+  public PartialPath getPath() {
+    return this.path;
+  }
+
+  public int getLimit() {
+    return limit;
+  }
+
+  public void setLimit(int limit) {
+    this.limit = limit;
+  }
+
+  public int getOffset() {
+    return offset;
+  }
+
+  public void setOffset(int offset) {
+    this.offset = offset;
+  }
+
+  public boolean hasLimit() {
+    return hasLimit;
+  }

Review comment:
       The sonar test shows these lines are duplicated with some lines in `ShowTimeseriesPlan`. How do you think remove the lines in `ShowTimeseriesPlan`? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org