You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/11 01:46:55 UTC

[GitHub] [pulsar] zplinuxlover commented on a change in pull request #6758: change test case code org.apache.pulsar.io.PulsarFunctionE2ETest#testFunctionAutomaticSubCleanup

zplinuxlover commented on a change in pull request #6758:
URL: https://github.com/apache/pulsar/pull/6758#discussion_r422739043



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarFunctionE2ETest.java
##########
@@ -1509,8 +1513,9 @@ public void testFunctionAutomaticSubCleanup() throws Exception {
 
         retryStrategically((test) -> {
             try {
+                // should remove `result.getParallelism() == 2` because the parallelism here should 1
                 FunctionConfig result = admin.functions().getFunction(tenant, namespacePortion, functionName);
-                return result.getParallelism() == 2 && result.getCleanupSubscription() == false;
+                return /*result.getParallelism() == 2 &&*/ result.getCleanupSubscription() == false;

Review comment:
       OK




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org