You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/17 22:31:48 UTC
[GitHub] [dubbo] CrazyHZM commented on a change in pull request #8782: [3.0]Fix nacos admin protocol cant't get interface name
CrazyHZM commented on a change in pull request #8782:
URL: https://github.com/apache/dubbo/pull/8782#discussion_r711382996
##########
File path: dubbo-registry/dubbo-registry-nacos/src/main/java/org/apache/dubbo/registry/nacos/NacosRegistry.java
##########
@@ -228,12 +229,19 @@ private void doSubscribe(final URL url, final NotifyListener listener, final Set
subscribeEventListener(serviceName, url, listener);
}
} else {
- List<Instance> instances = new LinkedList<>();
for (String serviceName : serviceNames) {
+ List<Instance> instances = new LinkedList<>();
instances.addAll(namingService.getAllInstances(serviceName
, getUrl().getGroup(Constants.DEFAULT_GROUP)));
- notifySubscriber(url, listener, instances);
- subscribeEventListener(serviceName, url, listener);
+ String serviceInterface = serviceName;
+ String[] segments = serviceName.split(SERVICE_NAME_SEPARATOR, -1);
+ if (segments.length == 4) {
+ serviceInterface = segments[SERVICE_INTERFACE_INDEX];
+ }
+ URL subscriberURL = url.setPath(serviceInterface).addParameters(INTERFACE_KEY, serviceInterface,
+ CHECK_KEY, String.valueOf(false));
Review comment:
The value of check should not be set here.
Why should the value of check be directly set to false?
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org