You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "scottsignal (via GitHub)" <gi...@apache.org> on 2024/07/15 13:57:30 UTC
[I] extraconfig parameter unable to be set via Domain Admin [cloudstack]
scottsignal opened a new issue, #9397:
URL: https://github.com/apache/cloudstack/issues/9397
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and main branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Bug Report
##### COMPONENT NAME
<!--
-->
~~~
API
~~~
##### CLOUDSTACK VERSION
<!--
-->
~~~
4.19.02
~~~
##### CONFIGURATION
<!--
Information about the configuration if relevant, e.g. basic network, advanced networking, etc. N/A otherwise
-->
Ubuntu 22.04
KVM
##### OS / ENVIRONMENT
<!--
Information about the environment if relevant, N/A otherwise
-->
N/A
##### SUMMARY
<!-- Explain the problem/feature briefly -->
A user in an account with the default out of the box role "Domain Admin" is unable to add the extraconfig parameter via API. Running this same API command as Root Admin works just fine.
##### STEPS TO REPRODUCE
<!--
For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
For new features, show how the feature would be used.
-->
Ensure that the 2 options are set and reboot mgmt:
allow.additional.vm.configuration.list.kvm = backend, tpm, devices
Enable additional vm configuration = enabled
Build an account & user with the out of the box role "Domain Admin"
Build an instance normally, however, make sure the Start Instance ratio is unselected at the bottom.
Run the API command to modify add the extra config. Running this command does not work under an account with out of the box default "Domain Admin" role.
<!-- Paste example playbooks or commands between quotes below -->
~~~
https://example.com/client/api?command=updateVirtualMachine&id=<ID_Here>&extraconfig=%3Cdevices%3E%0A%3Ctpm%20model%3D%22tpm-tis%22%3E%0A%3Cbackend%20type%3D%22emulator%22%20version%3D%222.0%22%2F%3E%0A%3C%2Ftpm%3E%0A%3C%2Fdevices%3E
~~~
<!-- You can also paste gist.github.com links for larger files -->
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
extraconfig added to the VM.
##### ACTUAL RESULTS
<!-- What actually happened? -->
API returns results with no error, however, extraconfig is not added.
<!-- Paste verbatim command output between quotes below -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] extraconfig parameter unable to be set via Domain Admin [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #9397:
URL: https://github.com/apache/cloudstack/issues/9397#issuecomment-2303919829
fixed in #9422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] extraconfig parameter unable to be set via Domain Admin [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on issue #9397:
URL: https://github.com/apache/cloudstack/issues/9397#issuecomment-2238937822
Yes @DaanHoogland - the access is already in place using these configurations as far as I know so only editing the access should work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] extraconfig parameter unable to be set via Domain Admin [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #9397:
URL: https://github.com/apache/cloudstack/issues/9397#issuecomment-2228669286
@scottsignal
it is expected, only root admin can set extraconfig
refer to
https://github.com/apache/cloudstack/blob/afdf4d7d46c0ce4e85da12140f9e140d5f4fe490/api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java#L144-L145
it has `authorized = { RoleType.Admin }`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] extraconfig parameter unable to be set via Domain Admin [cloudstack]
Posted by "scottsignal (via GitHub)" <gi...@apache.org>.
scottsignal commented on issue #9397:
URL: https://github.com/apache/cloudstack/issues/9397#issuecomment-2228705173
> we could remove the restriction, as the extraconfig is allowed when deploy a vm
Unless there is good reason to not. At a minimum, it would be nice to allow that not to be hard coded and be able to select roles to be selected in global settings for additional roles to add additional extraconfig. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] extraconfig parameter unable to be set via Domain Admin [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #9397:
URL: https://github.com/apache/cloudstack/issues/9397#issuecomment-2238551188
Ok, so we can change the hard-coding to allow access to the parameter for all and "just" check the global settings during the call, right @nvazquez ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] extraconfig parameter unable to be set via Domain Admin [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed issue #9397: extraconfig parameter unable to be set via Domain Admin
URL: https://github.com/apache/cloudstack/issues/9397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] extraconfig parameter unable to be set via Domain Admin [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on issue #9397:
URL: https://github.com/apache/cloudstack/issues/9397#issuecomment-2237089501
I agree with @scottsignal - also there are global settings which can restrict the passing of the extra configs to the hypervisor side even though the extra configs are defined as VM settings:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] extraconfig parameter unable to be set via Domain Admin [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #9397:
URL: https://github.com/apache/cloudstack/issues/9397#issuecomment-2228673477
we could remove the restriction, as the extraconfig is allowed when deploy a vm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org