You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/12/01 07:20:02 UTC
[GitHub] [maven-site] kwin commented on a diff in pull request #346: [MNGSITE-501] Clarify profile jdk activation
kwin commented on code in PR #346:
URL: https://github.com/apache/maven-site/pull/346#discussion_r1036763893
##########
content/apt/guides/introduction/introduction-to-profiles.apt:
##########
@@ -127,11 +129,12 @@ mvn groupId:artifactId:goal -P profile-1,profile-2,?profile-3
Profiles can be automatically triggered based on the detected state of
the build environment. These triggers are specified via an <<<\<activation\>>>>
section in the profile itself. Currently, this detection is limited to
- prefix-matching of the JDK version, the presence of a system property or
- the value of a system property. Here are some examples.
+ matching of the JDK version, matching the operating system,
Review Comment:
Fixed in https://github.com/apache/maven-site/pull/346/commits/d93b461cf74b40dc8fb8ca96d8c6f6538be810be.
##########
content/apt/guides/introduction/introduction-to-profiles.apt:
##########
@@ -127,11 +129,12 @@ mvn groupId:artifactId:goal -P profile-1,profile-2,?profile-3
Profiles can be automatically triggered based on the detected state of
the build environment. These triggers are specified via an <<<\<activation\>>>>
section in the profile itself. Currently, this detection is limited to
- prefix-matching of the JDK version, the presence of a system property or
- the value of a system property. Here are some examples.
+ matching of the JDK version, matching the operating system,
+ the presence of a system property or the value of a system property. Here are some examples.
Review Comment:
Fixed in https://github.com/apache/maven-site/pull/346/commits/d93b461cf74b40dc8fb8ca96d8c6f6538be810be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org