[jira] [Commented] (THRIFT-3704) "TConnectedClient died: Could not refill buffer" message shown when using HTTP Server

["Roger Meier (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15182351#comment-15182351 ] 

Roger Meier commented on THRIFT-3704:
-------------------------------------

Yes, throwing {noformat}TTransportException::END_OF_FILE{noformat} is what we need here. It is handled by {noformat}src/thrift/server/TConnectedClient.cpp{noformat}.
and we do this on other transports as well.

> "TConnectedClient died: Could not refill buffer" message shown when using HTTP Server
> -------------------------------------------------------------------------------------
>
>                 Key: THRIFT-3704
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3704
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9.3
>         Environment: Linux 64bit and Linux arm
>            Reporter: Pascal Bach
>         Attachments: 0001-Modify-tutorial-server-to-use-HTTP-and-JSON-to-repro.patch, 0001-Treat-the-case-where-we-are-not-able-to-refill-the-b.patch
>
>
> When using {{THttpTransport}} after every request the server prints the following message:
> {{TConnectedClient died: Could not refill buffer}}
> However the operation seems to be completed successfully.
> It doesn't matter what protocol is used (JSON, Binary). The issue can be observed independent of the client used (C++, JavaScript in Browser).
> The error is thrown in the {{THttpTransport::refill}} function in the case where read from the transport returns 0.
> I'm not sure if throwing an exception there is really necessary?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)