You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/04/22 10:43:11 UTC

[GitHub] whanice opened a new pull request #1650: [Dubbo-warmup] can specified warmup weight in warmup time

whanice opened a new pull request #1650: [Dubbo-warmup] can specified warmup weight in warmup time
URL: https://github.com/apache/incubator-dubbo/pull/1650
 
 
   ## What is the purpose of the change
   
   The original logic for wamup is the weight increases with time.
   but I think we should provide another way: can specified warmup weight in warmup time
   
   ## Brief changelog
   
   add warmupweight property for service.
   
   ## Verifying this change
   
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
   - [] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
   - [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test).
   - [x] Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services