You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (JIRA)" <ji...@apache.org> on 2019/03/08 16:22:00 UTC

[jira] [Created] (SOLR-13308) Move SystemPropertiesRestoreRule to SolrTestCase

Erick Erickson created SOLR-13308:
-------------------------------------

             Summary: Move SystemPropertiesRestoreRule to SolrTestCase
                 Key: SOLR-13308
                 URL: https://issues.apache.org/jira/browse/SOLR-13308
             Project: Solr
          Issue Type: Improvement
      Security Level: Public (Default Security Level. Issues are Public)
    Affects Versions: master (9.0), 8.1
            Reporter: Erick Erickson
            Assignee: Erick Erickson


[~krisden] just traced flaky HDFS tests to not clearing sysprops, see the discussion at SOLR-13297.

Part of SOLR-13268 is to derive all Solr test classes from SolrTestCase.

Once that's pushed, does it make sense to put that rule in SolrTestCase so it gets performed automagically so this kind of error doesn't creep back in?

I don't know the details of how that rule is implemented or whether this makes sense at that level but wanted to discuss.

I've assigned it to myself, but that's just so I don't lose track of it, but anyone else who wants to pick it up please feel free.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org