You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by giuseppelt <gi...@git.apache.org> on 2017/06/17 10:24:16 UTC
[GitHub] cordova-plugin-file pull request #207: CB-12930: (windows) Fix getDirectory ...
GitHub user giuseppelt opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/207
CB-12930: (windows) Fix getDirectory trailing slash path
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Windows
### What does this PR do?
Fix the issue
### What testing has been done on this change?
Test on WP 8.1/10 and Desktop Win10
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/giuseppelt/cordova-plugin-file patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/207.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #207
----
commit 6555f2a9e2bbefbd464487b9aafbe5af5093a053
Author: giuseppelt <gi...@users.noreply.github.com>
Date: 2017-06-17T10:11:55Z
Fix getDirectory trailing slash path
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request #207: CB-12930: (windows) Fix getDirectory ...
Posted by adamhaile <gi...@git.apache.org>.
Github user adamhaile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/207#discussion_r136143196
--- Diff: src/windows/FileProxy.js ---
@@ -751,7 +751,13 @@ module.exports = {
if (!fs || !validName(path)){
fail(FileError.ENCODING_ERR);
return;
- }
+ }
+
+ //check trailing "/"
--- End diff --
Correct. I submitted a (dup) JIRA report that explains why this slash causes a failure downstream: https://issues.apache.org/jira/browse/CB-12945 .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file issue #207: CB-12930: (windows) Fix getDirectory trailin...
Posted by adamhaile <gi...@git.apache.org>.
Github user adamhaile commented on the issue:
https://github.com/apache/cordova-plugin-file/pull/207
This bug caused us a lot of pain in a production app. Any movement on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file issue #207: CB-12930: (windows) Fix getDirectory trailin...
Posted by cordova-qa <gi...@git.apache.org>.
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-file/pull/207
Cordova CI Build has completed successfully.
**Commit** - [Link](https://github.com/apache/cordova-plugin-file/pull/207/commits/6555f2a9e2bbefbd464487b9aafbe5af5093a053)
**Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/5/)
915 tests run, 7 skipped, 0 failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request #207: CB-12930: (windows) Fix getDirectory ...
Posted by janpio <gi...@git.apache.org>.
Github user janpio commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/207#discussion_r136139240
--- Diff: src/windows/FileProxy.js ---
@@ -751,7 +751,13 @@ module.exports = {
if (!fs || !validName(path)){
fail(FileError.ENCODING_ERR);
return;
- }
+ }
+
+ //check trailing "/"
--- End diff --
this actually removes a trailing slash, correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file issue #207: CB-12930: (windows) Fix getDirectory trailin...
Posted by cadesalaberry <gi...@git.apache.org>.
Github user cadesalaberry commented on the issue:
https://github.com/apache/cordova-plugin-file/pull/207
Key there, I would love this PR to be merged as well !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org