You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2022/06/28 17:23:58 UTC
[superset] 07/19: fix(home): Show home page tabs as pills instead of links (#20257)
This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch 2.0
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 3d850426ffd83d7f193b975e4dffca8b36f5740d
Author: smileydev <47...@users.noreply.github.com>
AuthorDate: Tue Jun 21 19:44:48 2022 -0400
fix(home): Show home page tabs as pills instead of links (#20257)
* fix(home): make to update the css style of links
* fix(home): make to fix lint issue
* fix(home): make to remove underline when tab is active
* fix(homes): make to fix the issue of tab
* fix(home): make to move styles to a tag
(cherry picked from commit a833674a8d3fff5c813d8204efb9350c4c89f7b6)
---
superset-frontend/src/components/Menu/index.tsx | 4 ++--
superset-frontend/src/views/components/SubMenu.tsx | 9 ++++++---
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/superset-frontend/src/components/Menu/index.tsx b/superset-frontend/src/components/Menu/index.tsx
index 988f9160c6..73858bc92e 100644
--- a/superset-frontend/src/components/Menu/index.tsx
+++ b/superset-frontend/src/components/Menu/index.tsx
@@ -25,8 +25,8 @@ const MenuItem = styled(AntdMenu.Item)`
}
&.ant-menu-item {
- height: ${({ theme }) => theme.gridUnit * 7}px;
- line-height: ${({ theme }) => theme.gridUnit * 7}px;
+ height: ${({ theme }) => theme.gridUnit * 8}px;
+ line-height: ${({ theme }) => theme.gridUnit * 8}px;
a {
border-bottom: none;
transition: background-color ${({ theme }) => theme.transitionTiming}s;
diff --git a/superset-frontend/src/views/components/SubMenu.tsx b/superset-frontend/src/views/components/SubMenu.tsx
index 617f9748a0..e51c1e8eca 100644
--- a/superset-frontend/src/views/components/SubMenu.tsx
+++ b/superset-frontend/src/views/components/SubMenu.tsx
@@ -97,7 +97,8 @@ const StyledHeader = styled.div`
a {
margin: 0;
- padding: ${({ theme }) => theme.gridUnit * 4}px;
+ padding: ${({ theme }) => theme.gridUnit * 2}px
+ ${({ theme }) => theme.gridUnit * 4}px;
line-height: ${({ theme }) => theme.gridUnit * 5}px;
&:hover {
@@ -112,7 +113,8 @@ const StyledHeader = styled.div`
}
&.active a {
- text-decoration: underline;
+ background: ${({ theme }) => theme.colors.secondary.light4};
+ border-radius: ${({ theme }) => theme.borderRadius}px;
}
}
@@ -122,7 +124,8 @@ const StyledHeader = styled.div`
li > a:hover,
li > a:focus,
li > div:hover,
- div > div:hover {
+ div > div:hover,
+ div > a:hover {
background: ${({ theme }) => theme.colors.secondary.light4};
border-bottom: none;
border-radius: ${({ theme }) => theme.borderRadius}px;