You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/05/22 11:08:53 UTC
Review Request 59442: Files view on IE 11- On Concatenating files or
downloading,
the concatenated or downloaded file occupies the entire UI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59442/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-21084
https://issues.apache.org/jira/browse/AMBARI-21084
Repository: ambari
Description
-------
Content-Disposition have been changed from inline to attachment to fix issues in IE while downlaoding files
Diffs
-----
contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java 10b7c9e
Diff: https://reviews.apache.org/r/59442/diff/1/
Testing
-------
Manual testing done.
Thanks,
venkat sairam
Re: Review Request 59442: Files view on IE 11- On Concatenating files
or
downloading, the concatenated or downloaded file occupies the entire UI.
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59442/#review175628
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On May 22, 2017, 11:08 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59442/
> -----------------------------------------------------------
>
> (Updated May 22, 2017, 11:08 a.m.)
>
>
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-21084
> https://issues.apache.org/jira/browse/AMBARI-21084
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Content-Disposition have been changed from inline to attachment to fix issues in IE while downlaoding files
>
>
> Diffs
> -----
>
> contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java 10b7c9e
>
>
> Diff: https://reviews.apache.org/r/59442/diff/1/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 59442: Files view on IE 11- On Concatenating files
or
downloading, the concatenated or downloaded file occupies the entire UI.
Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59442/#review175625
-----------------------------------------------------------
Ship it!
Ship It!
- DIPAYAN BHOWMICK
On May 22, 2017, 11:08 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59442/
> -----------------------------------------------------------
>
> (Updated May 22, 2017, 11:08 a.m.)
>
>
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-21084
> https://issues.apache.org/jira/browse/AMBARI-21084
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Content-Disposition have been changed from inline to attachment to fix issues in IE while downlaoding files
>
>
> Diffs
> -----
>
> contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java 10b7c9e
>
>
> Diff: https://reviews.apache.org/r/59442/diff/1/
>
>
> Testing
> -------
>
> Manual testing done.
>
>
> Thanks,
>
> venkat sairam
>
>