You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Michael Concini (JIRA)" <de...@myfaces.apache.org> on 2010/02/18 16:18:27 UTC
[jira] Created: (MYFACES-2564) facelets in an app with a 1.2 level
faces-config do not work
facelets in an app with a 1.2 level faces-config do not work
------------------------------------------------------------
Key: MYFACES-2564
URL: https://issues.apache.org/jira/browse/MYFACES-2564
Project: MyFaces Core
Issue Type: Bug
Components: JSR-314
Affects Versions: 2.0.0-beta
Reporter: Michael Concini
Assignee: Michael Concini
According to section 10.1.2 of the spec:
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2564) facelets in an app with a 1.2
level faces-config do not work
Posted by "Ganesh Jung (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835716#action_12835716 ]
Ganesh Jung commented on MYFACES-2564:
--------------------------------------
Sorry for being inaccurate in my previous post by saying "accept" and "reject". I now understand you're suggesting to disable the integrated JSF 2.0 facelets feature for older faces-config versions.
You might be missing the phrase "such an application must *not* continue to bundle the Facelets jar file along with the application". This says that an application that worked with JSF 1.2 plus facelets is supposed to work with JSF 2.0 without facelets *unchanged*.
IMHO setting the context param should be the only way to disable the integrated facelets feature. If a developer accidentally adds a jar with com.sun.facelets classes or an older faces-config to his application he would get caught by surprise if he suddenly realizes that MyFaces decided to turn his integrated facelets feature of. What could be the use of such a behaviour?
> facelets in an app with a 1.2 level faces-config do not work
> ------------------------------------------------------------
>
> Key: MYFACES-2564
> URL: https://issues.apache.org/jira/browse/MYFACES-2564
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta
> Reporter: Michael Concini
> Assignee: Michael Concini
>
> According to section 10.1.2 of the spec:
> The sole determinant to backwards compatibility lies in the answer to the question, "is there any Java
> code in the application, or in libraries used by the application, that extends from or depends on any class in package
> com.sun.facelets and/or its sub-packages?"
> ...
> If the answer to this question is "no", Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such
> an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set
> the Facelets configuration parameters.
> This implies that simply removing the pre-2.0 facelets bundle should allow the app to run properly again in a 2.0 runtime.
> The problem is that right now we're doing a check against the version in the faces-config in addition to checking for the context param and the availability of the com/sun/facelets classes. We should only be doing the latter, as the version in the faces-config should only be used for schema validation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2564) facelets in an app with a 1.2
level faces-config do not work
Posted by "Ganesh Jung (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835635#action_12835635 ]
Ganesh Jung commented on MYFACES-2564:
--------------------------------------
I agree with Michael in that the faces-config version is only for schema validation and may not be used to reject old versions.
It's the same problem as with old taglib.xml's. A facelets taglib may contain a faces-config version 1.1 or 1.2, but must be accepted by JSF 2.0. Thus Michael is correct in accepting them. Please check the example jar in MYFACES-2543 that MUST work with JSF 2.0 according to the spec.
Second argument is that the reference implemetation is working correctly here - it allows old faces-config versions.
Third argument here: JSF 1.2 did accept 1.1 faces-configs, so why should JSF 2.0 discontinue support for 1.1 or 1.2 versions? If backward compatibilty was dropped here it would need to be explicitly stated by te spec, but I see no reason to do this.
> facelets in an app with a 1.2 level faces-config do not work
> ------------------------------------------------------------
>
> Key: MYFACES-2564
> URL: https://issues.apache.org/jira/browse/MYFACES-2564
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta
> Reporter: Michael Concini
> Assignee: Michael Concini
>
> According to section 10.1.2 of the spec:
> The sole determinant to backwards compatibility lies in the answer to the question, "is there any Java
> code in the application, or in libraries used by the application, that extends from or depends on any class in package
> com.sun.facelets and/or its sub-packages?"
> ...
> If the answer to this question is "no", Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such
> an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set
> the Facelets configuration parameters.
> This implies that simply removing the pre-2.0 facelets bundle should allow the app to run properly again in a 2.0 runtime.
> The problem is that right now we're doing a check against the version in the faces-config in addition to checking for the context param and the availability of the com/sun/facelets classes. We should only be doing the latter, as the version in the faces-config should only be used for schema validation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2564) facelets in an app with a 1.2
level faces-config do not work
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835289#action_12835289 ]
Jakob Korherr commented on MYFACES-2564:
----------------------------------------
Please revert the changes, because on an JSF 1.2 application (faces-config version!="2.0") there are no integrated facelets ;)
Thus you have to use facelets 1.1.x!
> facelets in an app with a 1.2 level faces-config do not work
> ------------------------------------------------------------
>
> Key: MYFACES-2564
> URL: https://issues.apache.org/jira/browse/MYFACES-2564
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta
> Reporter: Michael Concini
> Assignee: Michael Concini
>
> According to section 10.1.2 of the spec:
> The sole determinant to backwards compatibility lies in the answer to the question, "is there any Java
> code in the application, or in libraries used by the application, that extends from or depends on any class in package
> com.sun.facelets and/or its sub-packages?"
> ...
> If the answer to this question is "no", Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such
> an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set
> the Facelets configuration parameters.
> This implies that simply removing the pre-2.0 facelets bundle should allow the app to run properly again in a 2.0 runtime.
> The problem is that right now we're doing a check against the version in the faces-config in addition to checking for the context param and the availability of the com/sun/facelets classes. We should only be doing the latter, as the version in the faces-config should only be used for schema validation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2564) facelets in an app with a 1.2
level faces-config do not work
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835679#action_12835679 ]
Jakob Korherr commented on MYFACES-2564:
----------------------------------------
I don't say we should reject older versions, I really don't!!
However a JSF 1.2 application (faces-config version="1.2") expects from its environment that there are no integrated facelets available. JSF 1.2 applications only know JSP. To run with facelets they have to bundle facelets-1.1.x. Thus we have to disable the integrated facelets-2 for those applications, because that's exactly what they would expect!
Am I missing something?
> facelets in an app with a 1.2 level faces-config do not work
> ------------------------------------------------------------
>
> Key: MYFACES-2564
> URL: https://issues.apache.org/jira/browse/MYFACES-2564
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta
> Reporter: Michael Concini
> Assignee: Michael Concini
>
> According to section 10.1.2 of the spec:
> The sole determinant to backwards compatibility lies in the answer to the question, "is there any Java
> code in the application, or in libraries used by the application, that extends from or depends on any class in package
> com.sun.facelets and/or its sub-packages?"
> ...
> If the answer to this question is "no", Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such
> an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set
> the Facelets configuration parameters.
> This implies that simply removing the pre-2.0 facelets bundle should allow the app to run properly again in a 2.0 runtime.
> The problem is that right now we're doing a check against the version in the faces-config in addition to checking for the context param and the availability of the com/sun/facelets classes. We should only be doing the latter, as the version in the faces-config should only be used for schema validation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2564) facelets in an app with a 1.2
level faces-config do not work
Posted by "Michael Concini (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835817#action_12835817 ]
Michael Concini commented on MYFACES-2564:
------------------------------------------
I can certainly agree with that Leonardo. We could certainly use MYFACES-2543 for hashing out the overarching facelets 1.x migration strategy since there has already been much active discussion around it.
It doesn't really matter to me whether we maintain these as two separate issues or if we consolidate this issue into 2543 as long as we ensure that they are both handled. I'll defer to those who have been involved in the community longer than I as to how these types of situations have typically been handled.
> facelets in an app with a 1.2 level faces-config do not work
> ------------------------------------------------------------
>
> Key: MYFACES-2564
> URL: https://issues.apache.org/jira/browse/MYFACES-2564
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta
> Reporter: Michael Concini
> Assignee: Michael Concini
>
> According to section 10.1.2 of the spec:
> The sole determinant to backwards compatibility lies in the answer to the question, "is there any Java
> code in the application, or in libraries used by the application, that extends from or depends on any class in package
> com.sun.facelets and/or its sub-packages?"
> ...
> If the answer to this question is "no", Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such
> an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set
> the Facelets configuration parameters.
> This implies that simply removing the pre-2.0 facelets bundle should allow the app to run properly again in a 2.0 runtime.
> The problem is that right now we're doing a check against the version in the faces-config in addition to checking for the context param and the availability of the com/sun/facelets classes. We should only be doing the latter, as the version in the faces-config should only be used for schema validation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2564) facelets in an app with a 1.2 level
faces-config do not work
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf resolved MYFACES-2564.
-----------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0-beta-3
applied org. fix + small corrections on the presence check for facelet view handler
> facelets in an app with a 1.2 level faces-config do not work
> ------------------------------------------------------------
>
> Key: MYFACES-2564
> URL: https://issues.apache.org/jira/browse/MYFACES-2564
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta
> Reporter: Michael Concini
> Assignee: Michael Concini
> Fix For: 2.0.0-beta-3
>
> Attachments: MYFACES-2564
>
>
> According to section 10.1.2 of the spec:
> The sole determinant to backwards compatibility lies in the answer to the question, "is there any Java
> code in the application, or in libraries used by the application, that extends from or depends on any class in package
> com.sun.facelets and/or its sub-packages?"
> ...
> If the answer to this question is "no", Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such
> an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set
> the Facelets configuration parameters.
> This implies that simply removing the pre-2.0 facelets bundle should allow the app to run properly again in a 2.0 runtime.
> The problem is that right now we're doing a check against the version in the faces-config in addition to checking for the context param and the availability of the com/sun/facelets classes. We should only be doing the latter, as the version in the faces-config should only be used for schema validation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2564) facelets in an app with a 1.2
level faces-config do not work
Posted by "Ganesh Jung (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835775#action_12835775 ]
Ganesh Jung commented on MYFACES-2564:
--------------------------------------
Which faces-configs do you check to decide whether facelets are disabled? There might be a few via the web.xml context param and some more with each jar on the classpath. Will facelets be disabled if any of the faces-configs is below 2.0? I don't think it would be ok to disable facelets, just because a jar containing some old faces-config is dropped on the classpath.
My concern is to have only one version of dojofaces.jar for JSF 1.1, 1.2 and 2.0 with RI as well as with MyFaces. The jar has got a faces-config 1.1 to define some managed beans, but it needs facelets to run the contained xhtmls. I've tested with Mojarra 2.0 since early beta and it always worked fine with integrated JSF 2.0 facelets.
And again the other question: What could be the possible use of an algorithm beyond the context-param that disables facelets?
> facelets in an app with a 1.2 level faces-config do not work
> ------------------------------------------------------------
>
> Key: MYFACES-2564
> URL: https://issues.apache.org/jira/browse/MYFACES-2564
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta
> Reporter: Michael Concini
> Assignee: Michael Concini
>
> According to section 10.1.2 of the spec:
> The sole determinant to backwards compatibility lies in the answer to the question, "is there any Java
> code in the application, or in libraries used by the application, that extends from or depends on any class in package
> com.sun.facelets and/or its sub-packages?"
> ...
> If the answer to this question is "no", Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such
> an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set
> the Facelets configuration parameters.
> This implies that simply removing the pre-2.0 facelets bundle should allow the app to run properly again in a 2.0 runtime.
> The problem is that right now we're doing a check against the version in the faces-config in addition to checking for the context param and the availability of the com/sun/facelets classes. We should only be doing the latter, as the version in the faces-config should only be used for schema validation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2564) facelets in an app with a 1.2
level faces-config do not work
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835722#action_12835722 ]
Jakob Korherr commented on MYFACES-2564:
----------------------------------------
No problem!
Hmm, I don't know. The developer would also have to remove the facelets-1.1.x view-handler from the faces-config... And when he does that he can also set his version attribute to "2.0", because he is now running on JSF 2.0 :D
When I implemented this check (not only for the context-parameter but also for the facelets-1.1.x view-handler and the version attribute) some weeks ago, I only did what mojarra did at that time, because it seemed appropriate to me.
> facelets in an app with a 1.2 level faces-config do not work
> ------------------------------------------------------------
>
> Key: MYFACES-2564
> URL: https://issues.apache.org/jira/browse/MYFACES-2564
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta
> Reporter: Michael Concini
> Assignee: Michael Concini
>
> According to section 10.1.2 of the spec:
> The sole determinant to backwards compatibility lies in the answer to the question, "is there any Java
> code in the application, or in libraries used by the application, that extends from or depends on any class in package
> com.sun.facelets and/or its sub-packages?"
> ...
> If the answer to this question is "no", Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such
> an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set
> the Facelets configuration parameters.
> This implies that simply removing the pre-2.0 facelets bundle should allow the app to run properly again in a 2.0 runtime.
> The problem is that right now we're doing a check against the version in the faces-config in addition to checking for the context param and the availability of the com/sun/facelets classes. We should only be doing the latter, as the version in the faces-config should only be used for schema validation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2564) facelets in an app with a 1.2
level faces-config do not work
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835789#action_12835789 ]
Matthias Weßendorf commented on MYFACES-2564:
---------------------------------------------
According to section 10.1.2 of the spec:....
If the answer is NO (which is the case for Michael and Ganesh, right?)
I understand it that way that "drop-in" backwards compatibilty is supported, right ?
=> No extra (odd) steps are required by the (poor) users.
Or am I simply wrong with that understanding ?
> facelets in an app with a 1.2 level faces-config do not work
> ------------------------------------------------------------
>
> Key: MYFACES-2564
> URL: https://issues.apache.org/jira/browse/MYFACES-2564
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta
> Reporter: Michael Concini
> Assignee: Michael Concini
>
> According to section 10.1.2 of the spec:
> The sole determinant to backwards compatibility lies in the answer to the question, "is there any Java
> code in the application, or in libraries used by the application, that extends from or depends on any class in package
> com.sun.facelets and/or its sub-packages?"
> ...
> If the answer to this question is "no", Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such
> an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set
> the Facelets configuration parameters.
> This implies that simply removing the pre-2.0 facelets bundle should allow the app to run properly again in a 2.0 runtime.
> The problem is that right now we're doing a check against the version in the faces-config in addition to checking for the context param and the availability of the com/sun/facelets classes. We should only be doing the latter, as the version in the faces-config should only be used for schema validation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2564) facelets in an app with a 1.2
level faces-config do not work
Posted by "Ganesh Jung (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835822#action_12835822 ]
Ganesh Jung commented on MYFACES-2564:
--------------------------------------
@Yury: No, the spec says: "... and must not continue to set the Facelets configuration parameters"
> facelets in an app with a 1.2 level faces-config do not work
> ------------------------------------------------------------
>
> Key: MYFACES-2564
> URL: https://issues.apache.org/jira/browse/MYFACES-2564
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta
> Reporter: Michael Concini
> Assignee: Michael Concini
>
> According to section 10.1.2 of the spec:
> The sole determinant to backwards compatibility lies in the answer to the question, "is there any Java
> code in the application, or in libraries used by the application, that extends from or depends on any class in package
> com.sun.facelets and/or its sub-packages?"
> ...
> If the answer to this question is "no", Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such
> an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set
> the Facelets configuration parameters.
> This implies that simply removing the pre-2.0 facelets bundle should allow the app to run properly again in a 2.0 runtime.
> The problem is that right now we're doing a check against the version in the faces-config in addition to checking for the context param and the availability of the com/sun/facelets classes. We should only be doing the latter, as the version in the faces-config should only be used for schema validation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2564) facelets in an app with a 1.2
level faces-config do not work
Posted by "Yury Kats (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835792#action_12835792 ]
Yury Kats commented on MYFACES-2564:
------------------------------------
Interesting point, would this also imply that facelets-1.x view handler definition should be ignored?
> facelets in an app with a 1.2 level faces-config do not work
> ------------------------------------------------------------
>
> Key: MYFACES-2564
> URL: https://issues.apache.org/jira/browse/MYFACES-2564
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta
> Reporter: Michael Concini
> Assignee: Michael Concini
>
> According to section 10.1.2 of the spec:
> The sole determinant to backwards compatibility lies in the answer to the question, "is there any Java
> code in the application, or in libraries used by the application, that extends from or depends on any class in package
> com.sun.facelets and/or its sub-packages?"
> ...
> If the answer to this question is "no", Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such
> an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set
> the Facelets configuration parameters.
> This implies that simply removing the pre-2.0 facelets bundle should allow the app to run properly again in a 2.0 runtime.
> The problem is that right now we're doing a check against the version in the faces-config in addition to checking for the context param and the availability of the com/sun/facelets classes. We should only be doing the latter, as the version in the faces-config should only be used for schema validation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2564) facelets in an app with a 1.2
level faces-config do not work
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835791#action_12835791 ]
Leonardo Uribe commented on MYFACES-2564:
-----------------------------------------
The patch is valid but we need to solve MYFACES-2543 and this one at the same time.
It is important to define a precise and clear algorithm about what we should do in each case. Trying to fix it without a clear plan about how it works is a waste of time in my personal opinion.
> facelets in an app with a 1.2 level faces-config do not work
> ------------------------------------------------------------
>
> Key: MYFACES-2564
> URL: https://issues.apache.org/jira/browse/MYFACES-2564
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta
> Reporter: Michael Concini
> Assignee: Michael Concini
>
> According to section 10.1.2 of the spec:
> The sole determinant to backwards compatibility lies in the answer to the question, "is there any Java
> code in the application, or in libraries used by the application, that extends from or depends on any class in package
> com.sun.facelets and/or its sub-packages?"
> ...
> If the answer to this question is "no", Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such
> an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set
> the Facelets configuration parameters.
> This implies that simply removing the pre-2.0 facelets bundle should allow the app to run properly again in a 2.0 runtime.
> The problem is that right now we're doing a check against the version in the faces-config in addition to checking for the context param and the availability of the com/sun/facelets classes. We should only be doing the latter, as the version in the faces-config should only be used for schema validation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (MYFACES-2564) facelets in an app with a 1.2 level
faces-config do not work
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Korherr reopened MYFACES-2564:
------------------------------------
> facelets in an app with a 1.2 level faces-config do not work
> ------------------------------------------------------------
>
> Key: MYFACES-2564
> URL: https://issues.apache.org/jira/browse/MYFACES-2564
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta
> Reporter: Michael Concini
> Assignee: Michael Concini
>
> According to section 10.1.2 of the spec:
> The sole determinant to backwards compatibility lies in the answer to the question, "is there any Java
> code in the application, or in libraries used by the application, that extends from or depends on any class in package
> com.sun.facelets and/or its sub-packages?"
> ...
> If the answer to this question is "no", Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such
> an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set
> the Facelets configuration parameters.
> This implies that simply removing the pre-2.0 facelets bundle should allow the app to run properly again in a 2.0 runtime.
> The problem is that right now we're doing a check against the version in the faces-config in addition to checking for the context param and the availability of the com/sun/facelets classes. We should only be doing the latter, as the version in the faces-config should only be used for schema validation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2564) facelets in an app with a 1.2
level faces-config do not work
Posted by "Ganesh Jung (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835826#action_12835826 ]
Ganesh Jung commented on MYFACES-2564:
--------------------------------------
I'd prefer keeping two separate threads, because I think the issues need separate discussion.
IMHO the strategy for this one is extremely easy: Disable facelets *only* if the context param is set. I cannot see the use of any algorithm that kicks the facelets support away though the developer hasn't configured the system to do so.
> facelets in an app with a 1.2 level faces-config do not work
> ------------------------------------------------------------
>
> Key: MYFACES-2564
> URL: https://issues.apache.org/jira/browse/MYFACES-2564
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-beta
> Reporter: Michael Concini
> Assignee: Michael Concini
>
> According to section 10.1.2 of the spec:
> The sole determinant to backwards compatibility lies in the answer to the question, "is there any Java
> code in the application, or in libraries used by the application, that extends from or depends on any class in package
> com.sun.facelets and/or its sub-packages?"
> ...
> If the answer to this question is "no", Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such
> an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set
> the Facelets configuration parameters.
> This implies that simply removing the pre-2.0 facelets bundle should allow the app to run properly again in a 2.0 runtime.
> The problem is that right now we're doing a check against the version in the faces-config in addition to checking for the context param and the availability of the com/sun/facelets classes. We should only be doing the latter, as the version in the faces-config should only be used for schema validation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.