You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/12/04 00:35:21 UTC
[GitHub] [phoenix] stoty commented on pull request #975: PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…
stoty commented on pull request #975:
URL: https://github.com/apache/phoenix/pull/975#issuecomment-738472989
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 11m 14s | 4.x passed |
| +1 :green_heart: | compile | 0m 57s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 54s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 44s | 4.x passed |
| +0 :ok: | spotbugs | 3m 4s | phoenix-core in 4.x has 950 extant spotbugs warnings. |
| -0 :warning: | patch | 3m 11s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 45s | the patch passed |
| +1 :green_heart: | compile | 0m 57s | the patch passed |
| +1 :green_heart: | javac | 0m 57s | the patch passed |
| -1 :x: | checkstyle | 1m 10s | phoenix-core: The patch generated 532 new + 1111 unchanged - 4 fixed = 1643 total (was 1115) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 46s | the patch passed |
| -1 :x: | spotbugs | 3m 12s | phoenix-core generated 5 new + 950 unchanged - 0 fixed = 955 total (was 950) |
||| _ Other Tests _ |
| -1 :x: | unit | 134m 34s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 42s | The patch does not generate ASF License warnings. |
| | | 167m 25s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:[line 185] |
| | Integral value cast to double and then passed to Math.ceil in org.apache.phoenix.mapreduce.util.DefaultMultiViewSplitStrategy.getNumberOfMappers(int, int) At DefaultMultiViewSplitStrategy.java:and then passed to Math.ceil in org.apache.phoenix.mapreduce.util.DefaultMultiViewSplitStrategy.getNumberOfMappers(int, int) At DefaultMultiViewSplitStrategy.java:[line 58] |
| | org.apache.phoenix.mapreduce.util.DefaultPhoenixMultiViewListProvider.getTenantOrViewMultiViewList(Configuration) may fail to clean up java.sql.ResultSet Obligation to clean up resource created at DefaultPhoenixMultiViewListProvider.java:up java.sql.ResultSet Obligation to clean up resource created at DefaultPhoenixMultiViewListProvider.java:[line 110] is not discharged |
| | Boxing/unboxing to parse a primitive org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewQueryMoreSplitSize(Configuration) At PhoenixConfigurationUtil.java:org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewQueryMoreSplitSize(Configuration) At PhoenixConfigurationUtil.java:[line 451] |
| | Boxing/unboxing to parse a primitive org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewSplitSize(Configuration) At PhoenixConfigurationUtil.java:org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewSplitSize(Configuration) At PhoenixConfigurationUtil.java:[line 481] |
| Failed junit tests | phoenix.end2end.DeleteIT |
| | phoenix.end2end.DropIndexedColsIT |
| | phoenix.end2end.AlterMultiTenantTableWithViewsIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/6/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/975 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 7ca47fdc3495 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 5e70f76 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/6/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/6/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/6/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/6/testReport/ |
| Max. process+thread count | 6693 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/6/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org