You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/06/10 13:14:38 UTC
[GitHub] [incubator-kyuubi] turboFei opened a new pull request, #2856: renew token when opening session
turboFei opened a new pull request, #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r896299523
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkTBinaryFrontendService.scala:
##########
@@ -75,6 +64,13 @@ class SparkTBinaryFrontendService(
val respConfiguration = new java.util.HashMap[String, String]()
respConfiguration.put("kyuubi.engine.id", sc.applicationId)
+ if (req.getConfiguration != null) {
Review Comment:
@turboFei seems this comment has not been addressed, can you look at it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r894642088
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkTBinaryFrontendService.scala:
##########
@@ -65,10 +63,8 @@ class SparkTBinaryFrontendService(
respConfiguration.put("kyuubi.engine.id", sc.applicationId)
if (req.getConfiguration != null) {
- req.getConfiguration.asScala.get(KyuubiReservedKeys.KYUUBI_ENGINE_CREDENTIALS_KEY).filter(
- _.nonEmpty).foreach { credentials =>
- renewDelegationToken(credentials)
- }
+ val credentials = req.getConfiguration.remove(KYUUBI_ENGINE_CREDENTIALS_KEY)
Review Comment:
Not all Map support `remove` operation, but here, it seems that the thrift request supports `remove`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r895270056
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -106,7 +108,9 @@ class KyuubiSessionImpl(
Option(password).filter(_.nonEmpty).getOrElse("anonymous")
}
try {
- _client = KyuubiSyncThriftClient.createClient(user, passwd, host, port, sessionConf)
+ val engineSessionConf = sessionConf.clone
+ engineSessionConf.set(KyuubiReservedKeys.KYUUBI_ENGINE_CREDENTIALS_KEY, engineCredentials)
Review Comment:
Seems we can not put it into optimizedConf, it might be passed to SparkProcessBuilder and will be passed to engine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r894617923
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkTBinaryFrontendService.scala:
##########
@@ -75,6 +64,13 @@ class SparkTBinaryFrontendService(
val respConfiguration = new java.util.HashMap[String, String]()
respConfiguration.put("kyuubi.engine.id", sc.applicationId)
+ if (req.getConfiguration != null) {
Review Comment:
cc @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r896317201
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala:
##########
@@ -179,7 +179,13 @@ object SparkSQLEngine extends Logging {
}
def createSpark(): SparkSession = {
+ val credentials = _sparkConf.getOption(KyuubiReservedKeys.KYUUBI_ENGINE_CREDENTIALS_KEY)
+ _sparkConf.remove(KyuubiReservedKeys.KYUUBI_ENGINE_CREDENTIALS_KEY)
+
val session = SparkSession.builder.config(_sparkConf).getOrCreate
+
+ credentials.foreach(SparkTBinaryFrontendService.renewDelegationToken(session.sparkContext, _))
Review Comment:
cc @yaooqinn @ulysses-you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r896329946
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala:
##########
@@ -179,7 +179,15 @@ object SparkSQLEngine extends Logging {
}
def createSpark(): SparkSession = {
+ val engineCredentials = _sparkConf.getOption(KyuubiReservedKeys.KYUUBI_ENGINE_CREDENTIALS_KEY)
Review Comment:
thanks, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r896423694
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -67,6 +68,9 @@ class KyuubiSessionImpl(
case (key, value) => sessionConf.set(key, value)
}
+ private val engineCredentials = renewEngineCredentials()
+ sessionConf.set(KYUUBI_ENGINE_CREDENTIALS_KEY, engineCredentials)
Review Comment:
we need transfer it into sessionConf for spark-submit process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#issuecomment-1152360665
cc @lightning-L @cxzl25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r895281837
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkTBinaryFrontendService.scala:
##########
@@ -75,6 +64,13 @@ class SparkTBinaryFrontendService(
val respConfiguration = new java.util.HashMap[String, String]()
respConfiguration.put("kyuubi.engine.id", sc.applicationId)
+ if (req.getConfiguration != null) {
Review Comment:
we can also pass token via startup spark configuations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r897795961
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -68,7 +68,10 @@ class KyuubiSessionImpl(
case (key, value) => sessionConf.set(key, value)
}
- var engine: EngineRef = _
+ private lazy val engineCredentials = renewEngineCredentials()
+
+ lazy val engine: EngineRef =
+ new EngineRef(sessionConf, user, handle.identifier.toString, sessionManager.applicationManager)
Review Comment:
how about this? @ulysses-you
set the `engineCredentials` and `EngineRef` be lazy val.
engineCredentials => set into sessionConf => new EngineRef => _client.openSession
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei closed pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
turboFei closed pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
URL: https://github.com/apache/incubator-kyuubi/pull/2856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cxzl25 commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
cxzl25 commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r894606889
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkTBinaryFrontendService.scala:
##########
@@ -75,6 +64,13 @@ class SparkTBinaryFrontendService(
val respConfiguration = new java.util.HashMap[String, String]()
respConfiguration.put("kyuubi.engine.id", sc.applicationId)
+ if (req.getConfiguration != null) {
Review Comment:
Now the token is updated using serialized credentials in `openSession`, but the initial engine initialization sql (`kyuubi.engine.initialize.sql`) may fail to execute.
For example, in master local mode, the engine does not have a Hive delegation token.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] cxzl25 commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
cxzl25 commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r894629477
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkTBinaryFrontendService.scala:
##########
@@ -75,6 +64,13 @@ class SparkTBinaryFrontendService(
val respConfiguration = new java.util.HashMap[String, String]()
respConfiguration.put("kyuubi.engine.id", sc.applicationId)
+ if (req.getConfiguration != null) {
Review Comment:
Yes, maybe we can delay the execution of the initialization sql.
Another advantage of doing this is that, in the long-running Spark on YARN, the token applied for by the app expires, but the driver (AM) fails and starts to retry, the initialization SQL will fail, and the engine will exit.
If the execution is delayed, the driver still has a chance to update the token.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r894642088
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkTBinaryFrontendService.scala:
##########
@@ -65,10 +63,8 @@ class SparkTBinaryFrontendService(
respConfiguration.put("kyuubi.engine.id", sc.applicationId)
if (req.getConfiguration != null) {
- req.getConfiguration.asScala.get(KyuubiReservedKeys.KYUUBI_ENGINE_CREDENTIALS_KEY).filter(
- _.nonEmpty).foreach { credentials =>
- renewDelegationToken(credentials)
- }
+ val credentials = req.getConfiguration.remove(KYUUBI_ENGINE_CREDENTIALS_KEY)
Review Comment:
Not all Map support `remove` operation, but here, it seems that the `req.getConfiguration` supports that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] wForget commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
wForget commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r895194111
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -106,7 +108,9 @@ class KyuubiSessionImpl(
Option(password).filter(_.nonEmpty).getOrElse("anonymous")
}
try {
- _client = KyuubiSyncThriftClient.createClient(user, passwd, host, port, sessionConf)
+ val engineSessionConf = sessionConf.clone
+ engineSessionConf.set(KyuubiReservedKeys.KYUUBI_ENGINE_CREDENTIALS_KEY, engineCredentials)
Review Comment:
The `engineSessionConf` doesn't seem to be passed to engine, put it in `optimizedConf`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r894619530
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkTBinaryFrontendService.scala:
##########
@@ -75,6 +64,13 @@ class SparkTBinaryFrontendService(
val respConfiguration = new java.util.HashMap[String, String]()
respConfiguration.put("kyuubi.engine.id", sc.applicationId)
+ if (req.getConfiguration != null) {
Review Comment:
@cxzl25
Seem that you can move the statements from `kyuubi.engine.initialize.sql` to `kyuubi.engine.session.initialize.sql` for the case you mentioned above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#issuecomment-1152545684
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2856?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2856](https://codecov.io/gh/apache/incubator-kyuubi/pull/2856?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (130a3bb) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/d958a2c8d5a8b9e4d555b5c74bfb5b3499d8b636?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d958a2c) will **decrease** coverage by `0.01%`.
> The diff coverage is `85.71%`.
```diff
@@ Coverage Diff @@
## master #2856 +/- ##
============================================
- Coverage 63.31% 63.29% -0.02%
Complexity 205 205
============================================
Files 485 485
Lines 21688 21696 +8
Branches 2859 2860 +1
============================================
+ Hits 13731 13732 +1
- Misses 6658 6660 +2
- Partials 1299 1304 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/kyuubi/config/KyuubiReservedKeys.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpUmVzZXJ2ZWRLZXlzLnNjYWxh) | `0.00% <ø> (ø)` | |
| [.../kyuubi/credentials/HadoopCredentialsManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jcmVkZW50aWFscy9IYWRvb3BDcmVkZW50aWFsc01hbmFnZXIuc2NhbGE=) | `92.80% <60.00%> (-1.32%)` | :arrow_down: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `76.31% <75.00%> (+0.64%)` | :arrow_up: |
| [...ubi/engine/spark/SparkTBinaryFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9TcGFya1RCaW5hcnlGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `83.33% <93.75%> (+0.90%)` | :arrow_up: |
| [...ala/org/apache/kyuubi/operation/LaunchEngine.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vTGF1bmNoRW5naW5lLnNjYWxh) | `84.61% <100.00%> (-5.39%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `80.82% <0.00%> (-1.37%)` | :arrow_down: |
| [...i/spark/connector/tpcds/TPCDSStatisticsUtils.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZW5zaW9ucy9zcGFyay9reXV1Ymktc3BhcmstY29ubmVjdG9yLXRwY2RzL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NwYXJrL2Nvbm5lY3Rvci90cGNkcy9UUENEU1N0YXRpc3RpY3NVdGlscy5zY2FsYQ==) | `39.78% <0.00%> (-1.08%)` | :arrow_down: |
| [...la/org/apache/kyuubi/session/AbstractSession.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0Fic3RyYWN0U2Vzc2lvbi5zY2FsYQ==) | `96.26% <0.00%> (-0.91%)` | :arrow_down: |
| [.../org/apache/kyuubi/events/KyuubiSessionEvent.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9ldmVudHMvS3l1dWJpU2Vzc2lvbkV2ZW50LnNjYWxh) | `93.33% <0.00%> (-0.22%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2856/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2856?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2856?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d958a2c...130a3bb](https://codecov.io/gh/apache/incubator-kyuubi/pull/2856?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r896326687
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala:
##########
@@ -179,7 +179,15 @@ object SparkSQLEngine extends Logging {
}
def createSpark(): SparkSession = {
+ val engineCredentials = _sparkConf.getOption(KyuubiReservedKeys.KYUUBI_ENGINE_CREDENTIALS_KEY)
Review Comment:
this is wrong, you should get the creds from kyuubiConf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r896307147
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkTBinaryFrontendService.scala:
##########
@@ -75,6 +64,13 @@ class SparkTBinaryFrontendService(
val respConfiguration = new java.util.HashMap[String, String]()
respConfiguration.put("kyuubi.engine.id", sc.applicationId)
+ if (req.getConfiguration != null) {
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r897445802
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -98,6 +98,19 @@ class KyuubiSessionImpl(
private[kyuubi] def openEngineSession(extraEngineLog: Option[OperationLog] = None): Unit = {
withDiscoveryClient(sessionConf) { discoveryClient =>
+ val engineCredentials = renewEngineCredentials()
+ var openEngineSessionConf = optimizedConf
+ if (engineCredentials.nonEmpty) {
+ sessionConf.set(KYUUBI_ENGINE_CREDENTIALS_KEY, engineCredentials)
+ openEngineSessionConf =
+ optimizedConf ++ Map(KYUUBI_ENGINE_CREDENTIALS_KEY -> engineCredentials)
+ }
+
+ engine = new EngineRef(
+ sessionConf,
Review Comment:
can we poll out renewEngineCredentials ? so we do not need change the initialization of EngineRef. Then the ordering looks like:
renewEngineCredentials -> new EngineRef -> openEngineSession
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#issuecomment-1159894254
The kyuubi.engine.credentials is still visible in spark ui.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r896412872
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -107,7 +111,11 @@ class KyuubiSessionImpl(
}
try {
_client = KyuubiSyncThriftClient.createClient(user, passwd, host, port, sessionConf)
- _engineSessionHandle = _client.openSession(protocol, user, passwd, optimizedConf)
+ _engineSessionHandle = _client.openSession(
+ protocol,
+ user,
+ passwd,
+ optimizedConf ++ Map(KYUUBI_ENGINE_CREDENTIALS_KEY -> engineCredentials))
Review Comment:
I think a more safer way is that check `engineCredentials` is vaildated before inject into engine, so if engine get the KYUUBI_ENGINE_CREDENTIALS_KEY that means it must has credentials.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r896440548
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -98,6 +98,19 @@ class KyuubiSessionImpl(
private[kyuubi] def openEngineSession(extraEngineLog: Option[OperationLog] = None): Unit = {
withDiscoveryClient(sessionConf) { discoveryClient =>
+ val engineCredentials = renewEngineCredentials()
+ var openEngineSessionConf = optimizedConf
+ if (engineCredentials.nonEmpty) {
+ sessionConf.set(KYUUBI_ENGINE_CREDENTIALS_KEY, engineCredentials)
+ openEngineSessionConf =
+ optimizedConf ++ Map(KYUUBI_ENGINE_CREDENTIALS_KEY -> engineCredentials)
+ }
+
+ engine = new EngineRef(
+ sessionConf,
Review Comment:
how about this?
@ulysses-you
we need transfer the config item to EngineRef
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r895270438
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -106,7 +108,9 @@ class KyuubiSessionImpl(
Option(password).filter(_.nonEmpty).getOrElse("anonymous")
}
try {
- _client = KyuubiSyncThriftClient.createClient(user, passwd, host, port, sessionConf)
+ val engineSessionConf = sessionConf.clone
+ engineSessionConf.set(KyuubiReservedKeys.KYUUBI_ENGINE_CREDENTIALS_KEY, engineCredentials)
Review Comment:
How about:
```
sessionConf.set(KyuubiReservedKeys.KYUUBI_ENGINE_CREDENTIALS_KEY, engineCredentials)
_client = KyuubiSyncThriftClient.createClient(user, passwd, host, port, sessionConf)
```
cc @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r897785373
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -98,6 +98,19 @@ class KyuubiSessionImpl(
private[kyuubi] def openEngineSession(extraEngineLog: Option[OperationLog] = None): Unit = {
withDiscoveryClient(sessionConf) { discoveryClient =>
+ val engineCredentials = renewEngineCredentials()
+ var openEngineSessionConf = optimizedConf
+ if (engineCredentials.nonEmpty) {
+ sessionConf.set(KYUUBI_ENGINE_CREDENTIALS_KEY, engineCredentials)
+ openEngineSessionConf =
+ optimizedConf ++ Map(KYUUBI_ENGINE_CREDENTIALS_KEY -> engineCredentials)
+ }
+
+ engine = new EngineRef(
+ sessionConf,
Review Comment:
`renewEngineCredentials` might block the launch engine operation handle return.
So, It is better to do that in `LaunchEngine` operation thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#issuecomment-1156498418
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] wForget commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
wForget commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r895281014
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -106,7 +108,9 @@ class KyuubiSessionImpl(
Option(password).filter(_.nonEmpty).getOrElse("anonymous")
}
try {
- _client = KyuubiSyncThriftClient.createClient(user, passwd, host, port, sessionConf)
+ val engineSessionConf = sessionConf.clone
+ engineSessionConf.set(KyuubiReservedKeys.KYUUBI_ENGINE_CREDENTIALS_KEY, engineCredentials)
Review Comment:
Sorry, I didn't express my idea exactly. I mean that we need to pass this configuration through the 'openSession' method instead of the 'createClient'`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r895279659
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -106,7 +108,9 @@ class KyuubiSessionImpl(
Option(password).filter(_.nonEmpty).getOrElse("anonymous")
}
try {
- _client = KyuubiSyncThriftClient.createClient(user, passwd, host, port, sessionConf)
+ val engineSessionConf = sessionConf.clone
+ engineSessionConf.set(KyuubiReservedKeys.KYUUBI_ENGINE_CREDENTIALS_KEY, engineCredentials)
Review Comment:
got it, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r896410650
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -67,6 +68,9 @@ class KyuubiSessionImpl(
case (key, value) => sessionConf.set(key, value)
}
+ private val engineCredentials = renewEngineCredentials()
+ sessionConf.set(KYUUBI_ENGINE_CREDENTIALS_KEY, engineCredentials)
Review Comment:
unnecessary ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a diff in pull request #2856: [KYUUBI #2708] Open engine session and renew engine credentials in the one
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on code in PR #2856:
URL: https://github.com/apache/incubator-kyuubi/pull/2856#discussion_r896427935
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -67,6 +68,9 @@ class KyuubiSessionImpl(
case (key, value) => sessionConf.set(key, value)
}
+ private val engineCredentials = renewEngineCredentials()
+ sessionConf.set(KYUUBI_ENGINE_CREDENTIALS_KEY, engineCredentials)
Review Comment:
ah, I missed read the code.. nvm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org