You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by ep...@apache.org on 2024/02/20 12:26:05 UTC
(airflow) 09/27: Use `next_url` instead of `next` (#37225)
This is an automated email from the ASF dual-hosted git repository.
ephraimanierobi pushed a commit to branch v2-8-test
in repository https://gitbox.apache.org/repos/asf/airflow.git
commit cced181d158ddc4fe2902448d43c5f879cb115e9
Author: Vincent <97...@users.noreply.github.com>
AuthorDate: Wed Feb 7 11:47:30 2024 -0500
Use `next_url` instead of `next` (#37225)
(cherry picked from commit daa2bceba181193d675dae575a55bc3f39aba192)
---
airflow/auth/managers/fab/fab_auth_manager.py | 2 +-
tests/auth/managers/fab/test_fab_auth_manager.py | 2 +-
tests/www/views/test_anonymous_as_admin_role.py | 5 ++++-
tests/www/views/test_views_tasks.py | 4 ++--
4 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/airflow/auth/managers/fab/fab_auth_manager.py b/airflow/auth/managers/fab/fab_auth_manager.py
index e05abc97d3..0b68e571aa 100644
--- a/airflow/auth/managers/fab/fab_auth_manager.py
+++ b/airflow/auth/managers/fab/fab_auth_manager.py
@@ -359,7 +359,7 @@ class FabAuthManager(BaseAuthManager):
if not self.security_manager.auth_view:
raise AirflowException("`auth_view` not defined in the security manager.")
if "next_url" in kwargs and kwargs["next_url"]:
- return url_for(f"{self.security_manager.auth_view.endpoint}.login", next=kwargs["next_url"])
+ return url_for(f"{self.security_manager.auth_view.endpoint}.login", next_url=kwargs["next_url"])
else:
return url_for(f"{self.security_manager.auth_view.endpoint}.login")
diff --git a/tests/auth/managers/fab/test_fab_auth_manager.py b/tests/auth/managers/fab/test_fab_auth_manager.py
index 36271b1199..bb9d507cbd 100644
--- a/tests/auth/managers/fab/test_fab_auth_manager.py
+++ b/tests/auth/managers/fab/test_fab_auth_manager.py
@@ -402,7 +402,7 @@ class TestFabAuthManager:
auth_manager_with_appbuilder.security_manager.auth_view = Mock()
auth_manager_with_appbuilder.security_manager.auth_view.endpoint = "test_endpoint"
auth_manager_with_appbuilder.get_url_login(next_url="next_url")
- mock_url_for.assert_called_once_with("test_endpoint.login", next="next_url")
+ mock_url_for.assert_called_once_with("test_endpoint.login", next_url="next_url")
@pytest.mark.db_test
def test_get_url_logout_when_auth_view_not_defined(self, auth_manager_with_appbuilder):
diff --git a/tests/www/views/test_anonymous_as_admin_role.py b/tests/www/views/test_anonymous_as_admin_role.py
index a78485ea97..895b885175 100644
--- a/tests/www/views/test_anonymous_as_admin_role.py
+++ b/tests/www/views/test_anonymous_as_admin_role.py
@@ -56,7 +56,10 @@ def test_delete_pool_anonymous_user_no_role(anonymous_client, pool_factory):
pool = pool_factory()
resp = anonymous_client.post(f"pool/delete/{pool.id}")
assert 302 == resp.status_code
- assert f"/login/?next={quote_plus(f'http://localhost/pool/delete/{pool.id}')}" == resp.headers["Location"]
+ assert (
+ f"/login/?next_url={quote_plus(f'http://localhost/pool/delete/{pool.id}')}"
+ == resp.headers["Location"]
+ )
def test_delete_pool_anonymous_user_as_admin(anonymous_client_as_admin, pool_factory):
diff --git a/tests/www/views/test_views_tasks.py b/tests/www/views/test_views_tasks.py
index ae8ecfb78f..1e64cfeeeb 100644
--- a/tests/www/views/test_views_tasks.py
+++ b/tests/www/views/test_views_tasks.py
@@ -713,13 +713,13 @@ def one_dag_perm_user_client(app):
def test_delete_just_dag_per_dag_permissions(new_dag_to_delete, per_dag_perm_user_client):
resp = per_dag_perm_user_client.post(
- f"delete?dag_id={new_dag_to_delete.dag_id}&next=/home", follow_redirects=True
+ f"delete?dag_id={new_dag_to_delete.dag_id}&next_url=/home", follow_redirects=True
)
check_content_in_response(f"Deleting DAG with id {new_dag_to_delete.dag_id}.", resp)
def test_delete_just_dag_resource_permissions(new_dag_to_delete, user_client):
- resp = user_client.post(f"delete?dag_id={new_dag_to_delete.dag_id}&next=/home", follow_redirects=True)
+ resp = user_client.post(f"delete?dag_id={new_dag_to_delete.dag_id}&next_url=/home", follow_redirects=True)
check_content_in_response(f"Deleting DAG with id {new_dag_to_delete.dag_id}.", resp)