You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/25 13:16:40 UTC
[GitHub] [arrow-rs] Ted-Jiang opened a new pull request, #2924: Add test for selection and_then
Ted-Jiang opened a new pull request, #2924:
URL: https://github.com/apache/arrow-rs/pull/2924
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ted-Jiang closed pull request #2924: Add test for selection and_then
Posted by GitBox <gi...@apache.org>.
Ted-Jiang closed pull request #2924: Add test for selection and_then
URL: https://github.com/apache/arrow-rs/pull/2924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2924: Add test for selection and_then
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2924:
URL: https://github.com/apache/arrow-rs/pull/2924#discussion_r1005156169
##########
parquet/src/arrow/arrow_reader/selection.rs:
##########
@@ -455,11 +455,27 @@ mod tests {
RowSelector::select(2),
RowSelector::skip(1),
RowSelector::select(1),
- RowSelector::skip(4)
+ RowSelector::skip(4),
]
);
}
+ #[test]
+ fn test_and_2() {
Review Comment:
Yes, as per the doc comment, and_then is for computing the resulting RowSelection when the provided RowSelection is the result of the computation "under" another. We can, and probably should add a separate `and` for combining together row selections
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2924: Add test for selection and_then
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2924:
URL: https://github.com/apache/arrow-rs/pull/2924#discussion_r1004931406
##########
parquet/src/arrow/arrow_reader/selection.rs:
##########
@@ -455,11 +455,27 @@ mod tests {
RowSelector::select(2),
RowSelector::skip(1),
RowSelector::select(1),
- RowSelector::skip(4)
+ RowSelector::skip(4),
]
);
}
+ #[test]
+ fn test_and_2() {
Review Comment:
The test output should be
```
RowSelector::select(3),
RowSelector::skip(33),
RowSelector::select(3),
RowSelector::skip(33),
```
Although it is worth noting that the b selection is a little bit odd as it covers a range larger than that selected by a?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2924: Add test for selection and_then
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2924:
URL: https://github.com/apache/arrow-rs/pull/2924#discussion_r1004918765
##########
parquet/src/arrow/arrow_reader/selection.rs:
##########
@@ -455,11 +455,27 @@ mod tests {
RowSelector::select(2),
RowSelector::skip(1),
RowSelector::select(1),
- RowSelector::skip(4)
+ RowSelector::skip(4),
]
);
}
+ #[test]
+ fn test_and_2() {
Review Comment:
Yup, that doesn't look correct :sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #2924: Add test for selection and_then
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on code in PR #2924:
URL: https://github.com/apache/arrow-rs/pull/2924#discussion_r1005155564
##########
parquet/src/arrow/arrow_reader/selection.rs:
##########
@@ -455,11 +455,27 @@ mod tests {
RowSelector::select(2),
RowSelector::skip(1),
RowSelector::select(1),
- RowSelector::skip(4)
+ RowSelector::skip(4),
]
);
}
+ #[test]
+ fn test_and_2() {
Review Comment:
@tustvold
> Although it is worth noting that the b selection is a little bit odd as it covers a range larger than that selected by a? b is a selection of the 6 rows already selected by a
Is this assumption: last one must select less row than before one, only for `filter_pushdown`,
I create this two selections by apply filter on pageIndex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #2924: Add test for selection and_then
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on code in PR #2924:
URL: https://github.com/apache/arrow-rs/pull/2924#discussion_r1004498651
##########
parquet/src/arrow/arrow_reader/selection.rs:
##########
@@ -455,11 +455,27 @@ mod tests {
RowSelector::select(2),
RowSelector::skip(1),
RowSelector::select(1),
- RowSelector::skip(4)
+ RowSelector::skip(4),
]
);
}
+ #[test]
+ fn test_and_2() {
Review Comment:
seems this is a bug 🤔 @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2924: Add test for selection and_then
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2924:
URL: https://github.com/apache/arrow-rs/pull/2924#discussion_r1004931406
##########
parquet/src/arrow/arrow_reader/selection.rs:
##########
@@ -455,11 +455,27 @@ mod tests {
RowSelector::select(2),
RowSelector::skip(1),
RowSelector::select(1),
- RowSelector::skip(4)
+ RowSelector::skip(4),
]
);
}
+ #[test]
+ fn test_and_2() {
Review Comment:
The test output should be
```
RowSelector::select(3),
RowSelector::skip(33),
RowSelector::select(3),
RowSelector::skip(33),
```
Although it is worth noting that the b selection is a little bit odd as it covers a range larger than that selected by a? b is a selection of the 6 rows already selected by a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #2924: Add test for selection and_then
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #2924:
URL: https://github.com/apache/arrow-rs/pull/2924#issuecomment-1291242517
Created https://github.com/apache/arrow-rs/pull/2928/files to improve the panic messages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #2924: Add test for selection and_then
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on code in PR #2924:
URL: https://github.com/apache/arrow-rs/pull/2924#discussion_r1005161463
##########
parquet/src/arrow/arrow_reader/selection.rs:
##########
@@ -455,11 +455,27 @@ mod tests {
RowSelector::select(2),
RowSelector::skip(1),
RowSelector::select(1),
- RowSelector::skip(4)
+ RowSelector::skip(4),
]
);
}
+ #[test]
+ fn test_and_2() {
Review Comment:
>as per the doc comment
i missunder the computed under `self` 😂
> add a separate and for combining together row selections
Agree! will add this.
##########
parquet/src/arrow/arrow_reader/selection.rs:
##########
@@ -455,11 +455,27 @@ mod tests {
RowSelector::select(2),
RowSelector::skip(1),
RowSelector::select(1),
- RowSelector::skip(4)
+ RowSelector::skip(4),
]
);
}
+ #[test]
+ fn test_and_2() {
Review Comment:
>as per the doc comment
i missunder the computed under `self` 😂
> add a separate and for combining together row selections
Agree! will add this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org