[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2258: Core : remove the UnmodifiableMap

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #2258:
URL: https://github.com/apache/iceberg/pull/2258#discussion_r604397586



##########
File path: core/src/main/java/org/apache/iceberg/BaseFile.java
##########
@@ -434,7 +433,7 @@ public Integer sortOrderId() {
     if (map != null) {
       Map<K, V> copy = Maps.newHashMapWithExpectedSize(map.size());
       copy.putAll(map);
-      return Collections.unmodifiableMap(copy);

Review comment:
       I think Kryo in Spark somehow manages to handle unmodifiable collections. #775 came with a test and I also tested this recently in other places.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org