[GitHub] [arrow] thisisnic commented on a change in pull request #12433: ARROW-14808 [R] Implement bindings for `lubridate::date()`

[GitBox <gi...@apache.org>]

thisisnic commented on a change in pull request #12433:
URL: https://github.com/apache/arrow/pull/12433#discussion_r811830139



##########
File path: r/R/dplyr-funcs-datetime.R
##########
@@ -147,5 +147,7 @@ register_bindings_datetime <- function() {
   register_binding("pm", function(x) {
     !call_binding("am", x)
   })
-
+  register_binding("date", function(x) {
+    x$cast(date32())
+  })

Review comment:
       > Not sure what we want to achieve by calling a binding (in this case "date") on an R object
   
   I may be misinterpreting this, but I think maybe what Jon is getting at is whether you could do something like this in an arrow-dplyr chain:
   
   ```
   library(dplyr)
   library(lubridate)
   
   arbitrary_date_object <- ymd_hms("2012-03-26 23:12:13") + days(1:32)
   
   mtcars %>%
     mutate(x = date(arbitrary_date_object))
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org