You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2014/08/29 00:58:17 UTC

[1/3] git commit: HBASE-11846 HStore#assertBulkLoadHFileOk should log if a full HFile verification will be performed during a bulkload (Esteban Gutierrez)

Repository: hbase
Updated Branches:
  refs/heads/0.98 be8175231 -> d0b45a488
  refs/heads/branch-1 82c97342a -> 3d73ff13d
  refs/heads/master 452b1b729 -> 27ba04865


HBASE-11846 HStore#assertBulkLoadHFileOk should log if a full HFile verification will be performed during a bulkload (Esteban Gutierrez)


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/27ba0486
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/27ba0486
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/27ba0486

Branch: refs/heads/master
Commit: 27ba048651eb930175f9b157ee9019e0f08a86aa
Parents: 452b1b7
Author: Andrew Purtell <ap...@apache.org>
Authored: Thu Aug 28 15:53:19 2014 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Thu Aug 28 15:53:19 2014 -0700

----------------------------------------------------------------------
 .../main/java/org/apache/hadoop/hbase/regionserver/HStore.java  | 5 +++++
 1 file changed, 5 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/27ba0486/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
index dc593ac..a74a463 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
@@ -707,6 +707,8 @@ public class HStore implements Store {
       }
 
       if (verifyBulkLoads) {
+        long verificationStartTime = EnvironmentEdgeManager.currentTimeMillis();
+        LOG.info("Full verification started for bulk load hfile: " + srcPath.toString());
         Cell prevKV = null;
         HFileScanner scanner = reader.getScanner(false, false, false);
         scanner.seekTo();
@@ -732,6 +734,9 @@ public class HStore implements Store {
           }
           prevKV = kv;
         } while (scanner.next());
+      LOG.info("Full verification complete for bulk load hfile: " + srcPath.toString()
+         + " took " + (EnvironmentEdgeManager.currentTimeMillis() - verificationStartTime)
+         + " ms");
       }
     } finally {
       if (reader != null) reader.close();


[2/3] git commit: HBASE-11846 HStore#assertBulkLoadHFileOk should log if a full HFile verification will be performed during a bulkload (Esteban Gutierrez)

Posted by ap...@apache.org.
HBASE-11846 HStore#assertBulkLoadHFileOk should log if a full HFile verification will be performed during a bulkload (Esteban Gutierrez)


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/3d73ff13
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/3d73ff13
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/3d73ff13

Branch: refs/heads/branch-1
Commit: 3d73ff13d3cf38152382abef31aef848bcb6a1c0
Parents: 82c9734
Author: Andrew Purtell <ap...@apache.org>
Authored: Thu Aug 28 15:53:19 2014 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Thu Aug 28 15:53:27 2014 -0700

----------------------------------------------------------------------
 .../main/java/org/apache/hadoop/hbase/regionserver/HStore.java  | 5 +++++
 1 file changed, 5 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/3d73ff13/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
index 05a56c6..d44ce07 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
@@ -707,6 +707,8 @@ public class HStore implements Store {
       }
 
       if (verifyBulkLoads) {
+        long verificationStartTime = EnvironmentEdgeManager.currentTimeMillis();
+        LOG.info("Full verification started for bulk load hfile: " + srcPath.toString());
         Cell prevKV = null;
         HFileScanner scanner = reader.getScanner(false, false, false);
         scanner.seekTo();
@@ -732,6 +734,9 @@ public class HStore implements Store {
           }
           prevKV = kv;
         } while (scanner.next());
+      LOG.info("Full verification complete for bulk load hfile: " + srcPath.toString()
+         + " took " + (EnvironmentEdgeManager.currentTimeMillis() - verificationStartTime)
+         + " ms");
       }
     } finally {
       if (reader != null) reader.close();


[3/3] git commit: HBASE-11846 HStore#assertBulkLoadHFileOk should log if a full HFile verification will be performed during a bulkload (Esteban Gutierrez)

Posted by ap...@apache.org.
HBASE-11846 HStore#assertBulkLoadHFileOk should log if a full HFile verification will be performed during a bulkload (Esteban Gutierrez)

Amending-Author: Andrew Purtell <ap...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/d0b45a48
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/d0b45a48
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/d0b45a48

Branch: refs/heads/0.98
Commit: d0b45a488f40f082493a53fe49e3d85c6d6f0762
Parents: be81752
Author: Andrew Purtell <ap...@apache.org>
Authored: Thu Aug 28 15:53:19 2014 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Thu Aug 28 15:54:13 2014 -0700

----------------------------------------------------------------------
 .../main/java/org/apache/hadoop/hbase/regionserver/HStore.java  | 5 +++++
 1 file changed, 5 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/d0b45a48/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
index 7cb5dc2..f2c86e1 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
@@ -642,6 +642,8 @@ public class HStore implements Store {
       }
 
       if (verifyBulkLoads) {
+        long verificationStartTime = EnvironmentEdgeManager.currentTimeMillis();
+        LOG.info("Full verification started for bulk load hfile: " + srcPath.toString());
         KeyValue prevKV = null;
         HFileScanner scanner = reader.getScanner(false, false, false);
         scanner.seekTo();
@@ -667,6 +669,9 @@ public class HStore implements Store {
           }
           prevKV = kv;
         } while (scanner.next());
+      LOG.info("Full verification complete for bulk load hfile: " + srcPath.toString()
+         + " took " + (EnvironmentEdgeManager.currentTimeMillis() - verificationStartTime)
+         + " ms");
       }
     } finally {
       if (reader != null) reader.close();