[GitHub] michellethomas opened a new pull request #6269: Fixing time range since with no "ago"

[GitBox <gi...@apache.org>]

michellethomas opened a new pull request #6269: Fixing time range since with no "ago"
URL: https://github.com/apache/incubator-superset/pull/6269
 
 
   '7 days ago' is parsed correctly but we have some charts with since: 7 days until: now and it's treated as 7 days from now not since 7 days.
   
   It looks like this backwards compatibility hack was removed [here](https://github.com/apache/incubator-superset/pull/4981/files#diff-f451672348fc6071e8d627778bdc4e96L270), I'm not sure if there was a specific reason to remove it. 
   
   While looking into this issue, I noticed that the fix for annotations introduced an issue where a time range is always split into since/until which means that the UI will always show it as a custom start/end when the page is reloaded.
   
   The annotations override since / until will also have issues if the filter shown is the default 'No filter', the annotation will fail because it will be added as a since filter that get_since_until doesn't know what to do with.
   
   Overall these feel like a lot of hacky fixes because we didn't do a db migration for time range. If anyone has better suggestions or wants to migrate all since/until to time_range, let me know. 
   
   @john-bodley @graceguo-supercat @mistercrunch @betodealmeida 
   
   Fixes #6263

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org