You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2025/11/25 08:28:35 UTC

[PR] HDDS-13995. Improve summary for installation failure [ozone]

adoroszlai opened a new pull request, #9359:
URL: https://github.com/apache/ozone/pull/9359

   ## What changes were proposed in this pull request?
   
   - Provide better `Summary of failures` if some tool required for CI check cannot be installed.
   - When checking whether the tool is already installed, verify that the tool can be found (`which ...`).  This is useful for local runs, where one may re-try manually.  CI re-run always starts from a clean state.
   
   https://issues.apache.org/jira/browse/HDDS-13995
   
   ## How was this patch tested?
   
   Before:
   
   ```
   $ rm -fr .dev-tools target
   
   $ HUGO_VERSION=no-such-version ./hadoop-ozone/dev-support/checks/docs.sh
   ...
   Failed to install hugo
   
   $ cat target/docs/summary.txt
   cat: target/docs/summary.txt: No such file or directory
   ```
   
   After:
   
   ```
   $ rm -fr .dev-tools target
   
   $ HUGO_VERSION=no-such-version ./hadoop-ozone/dev-support/checks/docs.sh
   ...
   Failed to install hugo
   
   $ cat target/docs/summary.txt
   Failed to install hugo
   ```
   
   Re-run with valid (default) version:
   
   ```
   $ ./hadoop-ozone/dev-support/checks/docs.sh
   ...
   Installed hugo in .dev-tools/hugo
   WARN  DEPRECATED: Kind "taxonomyterm" used in disableKinds is deprecated, use "taxonomy" instead.
   Start building sites … 
   hugo v0.141.0-e7bd51698e5c3778a86003018702b1a7dcb9559a linux/amd64 BuildDate=2025-01-16T13:11:18Z VendorInfo=gohugoio
   ...
   Total in 564 ms
   ```
   
   CI:
   https://github.com/adoroszlai/ozone/actions/runs/19642627720


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-13995. Improve summary for installation failure [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #9359:
URL: https://github.com/apache/ozone/pull/9359


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-13995. Improve summary for installation failure [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #9359:
URL: https://github.com/apache/ozone/pull/9359#discussion_r2559595750


##########
hadoop-ozone/dev-support/checks/_lib.sh:
##########
@@ -40,13 +40,17 @@ _install_tool() {
     return
   fi
 
-  if [[ ! -d "${dir}" ]]; then
+  if [[ ! -d "${dir}" ]] || ! which "$bin" >& /dev/null; then
     mkdir -pv "${dir}"
     pushd "${dir}"
     if eval "${func}"; then

Review Comment:
   Thanks for the idea, but I don't think it's needed.  Full output is always available in the main `Execute tests` step, summary is supposed to be short.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-13995. Improve summary for installation failure [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #9359:
URL: https://github.com/apache/ozone/pull/9359#issuecomment-3577345474

   Thanks @devabhishekpal for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-13995. Improve summary for installation failure [ozone]

Posted by "devabhishekpal (via GitHub)" <gi...@apache.org>.
devabhishekpal commented on PR #9359:
URL: https://github.com/apache/ozone/pull/9359#issuecomment-3576925248

   @adoroszlai, seems like there are merge conflicts. Can you take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-13995. Improve summary for installation failure [ozone]

Posted by "devabhishekpal (via GitHub)" <gi...@apache.org>.
devabhishekpal commented on code in PR #9359:
URL: https://github.com/apache/ozone/pull/9359#discussion_r2559569425


##########
hadoop-ozone/dev-support/checks/_lib.sh:
##########
@@ -40,13 +40,17 @@ _install_tool() {
     return
   fi
 
-  if [[ ! -d "${dir}" ]]; then
+  if [[ ! -d "${dir}" ]] || ! which "$bin" >& /dev/null; then
     mkdir -pv "${dir}"
     pushd "${dir}"
     if eval "${func}"; then

Review Comment:
   Do you think it might be good to redirect the standard error to the output file as well?
   ```
   if eval "${func}" 2>> "${REPORT_FILE}"; then
   ```
   
   This would help us know what actually went wrong while trying to install the tool



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org