You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@answer.apache.org by "hgaol (via GitHub)" <gi...@apache.org> on 2025/03/26 11:12:03 UTC
[PR] fix(search/algolia): update answer filtering logic to align with search specifications [answer-plugins]
hgaol opened a new pull request, #286:
URL: https://github.com/apache/answer-plugins/pull/286
Minor fix for #238 .
To align with search specifications for this field. Pls let me know if it's expected and I can close this PR. :p
```go
// greater than or equal to the number of answers. Only support search question.
AnswerAmount int
```
https://github.com/apache/answer/blob/3b07b39d896ed755e44515ba8106d56132cc5439/plugin/search.go#L77
https://github.com/apache/answer-plugins/blob/68d6b7869830d27176ad93db01898c016703c88e/search-meilisearch/meilisearch.go#L372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(search/algolia): update answer filtering logic to align with search specifications [answer-plugins]
Posted by "hgaol (via GitHub)" <gi...@apache.org>.
hgaol closed pull request #286: fix(search/algolia): update answer filtering logic to align with search specifications
URL: https://github.com/apache/answer-plugins/pull/286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(search/algolia): update answer filtering logic to align with search specifications [answer-plugins]
Posted by "hgaol (via GitHub)" <gi...@apache.org>.
hgaol closed pull request #286: fix(search/algolia): update answer filtering logic to align with search specifications
URL: https://github.com/apache/answer-plugins/pull/286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(search/algolia): update answer filtering logic to align with search specifications [answer-plugins]
Posted by "hgaol (via GitHub)" <gi...@apache.org>.
hgaol commented on PR #286:
URL: https://github.com/apache/answer-plugins/pull/286#issuecomment-2788205791
Thanks @kumfo , I closed this PR since it's by design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(search/algolia): update answer filtering logic to align with search specifications [answer-plugins]
Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars commented on PR #286:
URL: https://github.com/apache/answer-plugins/pull/286#issuecomment-2754914118
It looks like your changes make sense. When `AnswerAmount` is 0, the query should actually be all of them. When it's not 0 it should be the query condition. let us ask @kumfo to confirm this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(search/algolia): update answer filtering logic to align with search specifications [answer-plugins]
Posted by "hgaol (via GitHub)" <gi...@apache.org>.
hgaol commented on PR #286:
URL: https://github.com/apache/answer-plugins/pull/286#issuecomment-2754059388
will do later based on dev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(search/algolia): update answer filtering logic to align with search specifications [answer-plugins]
Posted by "kumfo (via GitHub)" <gi...@apache.org>.
kumfo commented on PR #286:
URL: https://github.com/apache/answer-plugins/pull/286#issuecomment-2774390935
You should not change this code, when search conditions has `answers:0`, the search results should not include questions that have existing answers.
When `cond.AnswerAmount` is `-1`, the search result no limit. Could you please check [this code](https://github.com/apache/answer/blob/282e47c91227e3375b045263bada946dd511ab89/internal/service/search_parser/search_parser.go#L268)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org