You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wu-sheng (via GitHub)" <gi...@apache.org> on 2023/04/25 08:52:38 UTC

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #515: clickhouse-jdbc-plugin support trace sql parameters when enable plugin.jdbc.trace_sql_parameters

wu-sheng commented on code in PR #515:
URL: https://github.com/apache/skywalking-java/pull/515#discussion_r1176211682


##########
apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/define/StatementEnhanceInfos.java:
##########
@@ -38,6 +38,9 @@ public StatementEnhanceInfos(ConnectionInfo connectionInfo, String sql, String s
         this.statementName = statementName;
     }
 
+    public StatementEnhanceInfos() {

Review Comment:
   Why do you build an empty one? You can't get the necessary information?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org