You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by gracemeilen <gi...@git.apache.org> on 2016/08/02 18:07:20 UTC
[GitHub] incubator-geode pull request #223: GEODE-1712: introduce SecurityService and...
GitHub user gracemeilen opened a pull request:
https://github.com/apache/incubator-geode/pull/223
GEODE-1712: introduce SecurityService and unit tests for security
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gracemeilen/incubator-geode feature/GEODE-1712-3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/223.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #223
----
commit 70440b15fcebd1187e31c08da1142e56bea60b62
Author: gmeilen <gr...@gmail.com>
Date: 2016-07-18T20:13:11Z
GEODE-1712: introduce SecurityService interface for mocking
* create Unit Tests for client commands that use security
commit d5d91fb3e9ddd54887724d63a3fa93551e1719dc
Author: gmeilen <gr...@gmail.com>
Date: 2016-07-28T17:46:30Z
GEODE-1713: cleanup imports
commit 2b62775280fb5aff33c853278996884404d9392c
Author: gmeilen <gr...@gmail.com>
Date: 2016-07-28T20:20:23Z
GEODE-1712: add static factory methods to SecurityService
commit 453f5e95dfdd62756f033a6b416999dcfb6db854
Author: gmeilen <gr...@gmail.com>
Date: 2016-08-01T20:16:25Z
GEODE-1712: add missing categories and fix test failures
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #223: GEODE-1712: introduce SecurityService and...
Posted by gracemeilen <gi...@git.apache.org>.
Github user gracemeilen closed the pull request at:
https://github.com/apache/incubator-geode/pull/223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #223: GEODE-1712: introduce SecurityService and...
Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/223#discussion_r73215457
--- Diff: geode-core/src/main/java/com/gemstone/gemfire/internal/security/IntegratedSecurityService.java ---
@@ -0,0 +1,164 @@
+package com.gemstone.gemfire.internal.security;
+
+import java.util.Properties;
+import java.util.concurrent.Callable;
+
+import org.apache.geode.security.ResourcePermission;
+import org.apache.geode.security.SecurityManager;
+import org.apache.logging.log4j.Logger;
+import org.apache.shiro.subject.Subject;
+import org.apache.shiro.util.ThreadState;
+
+import com.gemstone.gemfire.internal.logging.LogService;
+import com.gemstone.gemfire.management.internal.security.ResourceOperation;
+
+public class IntegratedSecurityService implements SecurityService {
+
+ private static Logger logger = LogService.getLogger(LogService.SECURITY_LOGGER_NAME);
+
+ private static SecurityService defaultInstance = new IntegratedSecurityService();
+
--- End diff --
Can someone just call new IntegratedSecurityService()? If so, probably just create a private constructor here to prevent that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---