You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Farhan Khan <fa...@freestoneinfotech.com> on 2023/09/13 11:04:36 UTC

Review Request 74600: Atlas-4793: Search Issues

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74600/
-----------------------------------------------------------

Review request for atlas and Prasad Pawar.


Bugs: Atlas-4793
    https://issues.apache.org/jira/browse/Atlas-4793


Repository: atlas


Description
-------

1. Usually when a user enters a string in the quick search bar and presses Enter, Atlas should trigger the search for the same. But instead user is taken to a page with nothing displayed.

2. When user clicks on the suggestions listed in the quick search dropdown, user is taken to a page with nothing displayed.

3. When user attempts to select _ALL_ENTITY_TYPES in the basic search functionality, user is taken to a page with nothing displayed.


Diffs
-----

  dashboardv2/public/js/views/search/SearchResultLayoutView.js 03b9d5947 
  dashboardv3/public/js/views/search/SearchResultLayoutView.js 2d3d212a1 


Diff: https://reviews.apache.org/r/74600/diff/1/


Testing
-------

Manually tested for all the above mentioned scenarios and it is working fine.


Thanks,

Farhan Khan


Re: Review Request 74600: Atlas-4793: Search Issues

Posted by Prasad Pawar <pr...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74600/#review225758
-----------------------------------------------------------


Ship it!




Ship It!

- Prasad Pawar


On Sept. 13, 2023, 3:01 p.m., Farhan Khan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74600/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2023, 3:01 p.m.)
> 
> 
> Review request for atlas and Prasad Pawar.
> 
> 
> Bugs: Atlas-4793
>     https://issues.apache.org/jira/browse/Atlas-4793
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> 1. Usually when a user enters a string in the quick search bar and presses Enter, Atlas should trigger the search for the same. But instead user is taken to a page with nothing displayed.
> 
> 2. When user clicks on the suggestions listed in the quick search dropdown, user is taken to a page with nothing displayed.
> 
> 3. When user attempts to select _ALL_ENTITY_TYPES in the basic search functionality, user is taken to a page with nothing displayed.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js 03b9d5947 
>   dashboardv3/public/js/views/search/SearchResultLayoutView.js 2d3d212a1 
> 
> 
> Diff: https://reviews.apache.org/r/74600/diff/2/
> 
> 
> Testing
> -------
> 
> Manually tested for all the above mentioned scenarios and it is working fine.
> 
> 
> Thanks,
> 
> Farhan Khan
> 
>


Re: Review Request 74600: Atlas-4793: Search Issues

Posted by Farhan Khan <fa...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74600/
-----------------------------------------------------------

(Updated Sept. 13, 2023, 3:01 p.m.)


Review request for atlas and Prasad Pawar.


Bugs: Atlas-4793
    https://issues.apache.org/jira/browse/Atlas-4793


Repository: atlas


Description
-------

1. Usually when a user enters a string in the quick search bar and presses Enter, Atlas should trigger the search for the same. But instead user is taken to a page with nothing displayed.

2. When user clicks on the suggestions listed in the quick search dropdown, user is taken to a page with nothing displayed.

3. When user attempts to select _ALL_ENTITY_TYPES in the basic search functionality, user is taken to a page with nothing displayed.


Diffs (updated)
-----

  dashboardv2/public/js/views/search/SearchResultLayoutView.js 03b9d5947 
  dashboardv3/public/js/views/search/SearchResultLayoutView.js 2d3d212a1 


Diff: https://reviews.apache.org/r/74600/diff/2/

Changes: https://reviews.apache.org/r/74600/diff/1-2/


Testing
-------

Manually tested for all the above mentioned scenarios and it is working fine.


Thanks,

Farhan Khan