You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Antonio Andrade (JIRA)" <ji...@apache.org> on 2008/10/16 18:47:45 UTC
[jira] Created: (AXIS2-4090) WSDL11ToAxisServiceBuilder: Population
of AxisBindingMessage and AxisMessages objects is inconsistent when the
isServerSide flag is set to false
WSDL11ToAxisServiceBuilder: Population of AxisBindingMessage and AxisMessages objects is inconsistent when the isServerSide flag is set to false
------------------------------------------------------------------------------------------------------------------------------------------------
Key: AXIS2-4090
URL: https://issues.apache.org/jira/browse/AXIS2-4090
Project: Axis 2.0 (Axis2)
Issue Type: Bug
Components: kernel
Affects Versions: 1.4, nightly
Environment: Windows XP. 4GB RAM Intel Xeon dual-core @2.83Ghz
Reporter: Antonio Andrade
Observed Behavior:
Within the 'populateBinding' method, both the Message Exchange Pattern of the operation -axisOperation.getMessageExchangePattern()- and the message labels -WSDLConstants.MESSAGE_LABEL_XX_VALUE- depend on the 'isServerSide' flag but this dependency is ignored when the AxisBindingMessage and AxisMessage objects are being populated. This can be seen whenever the 'isServerSide' flag is set to 'false'.
Expected Behavior:
The value of both the operation's MEP and message labels should be retrieved taking into consideration the 'isServerSide' flag.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-4090) WSDL11ToAxisServiceBuilder: Population
of AxisBindingMessage and AxisMessages objects is inconsistent when the
isServerSide flag is set to false
Posted by "Antonio Andrade (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Andrade updated AXIS2-4090:
-----------------------------------
Attachment: JUnit Tests - Before.jpg
When 'isServerSide' is set to false, the XML schema elements associated with the corresponding AxisMessages are either null or contain the opposite schema element (i.e. input one when it should be ouput)
> WSDL11ToAxisServiceBuilder: Population of AxisBindingMessage and AxisMessages objects is inconsistent when the isServerSide flag is set to false
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: AXIS2-4090
> URL: https://issues.apache.org/jira/browse/AXIS2-4090
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: kernel
> Affects Versions: 1.4, nightly
> Environment: Windows XP. 4GB RAM Intel Xeon dual-core @2.83Ghz
> Reporter: Antonio Andrade
> Attachments: AXIS2-4090-JUnitTests.patch, AXIS2-4090.patch, JUnit Tests - Before.jpg
>
> Original Estimate: 6h
> Remaining Estimate: 6h
>
> Observed Behavior:
> Within the 'populateBinding' method, both the Message Exchange Pattern of the operation -axisOperation.getMessageExchangePattern()- and the message labels -WSDLConstants.MESSAGE_LABEL_XX_VALUE- depend on the 'isServerSide' flag but this dependency is ignored when the AxisBindingMessage and AxisMessage objects are being populated. This can be seen whenever the 'isServerSide' flag is set to 'false'.
> Expected Behavior:
> The value of both the operation's MEP and message labels should be retrieved taking into consideration the 'isServerSide' flag.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-4090) WSDL11ToAxisServiceBuilder: Population
of AxisBindingMessage and AxisMessages objects is inconsistent when the
isServerSide flag is set to false
Posted by "Antonio Andrade (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Andrade updated AXIS2-4090:
-----------------------------------
Attachment: AXIS2-4090-JUnitTests.patch
Submitting JUnit Tests. Ready for Review:
This is a data-drive test class that uses the WSDL document attached ('wsdl/meps-wsdl11.wsdl') to verify that operations' MEPs, message labels, message directions AND schema elements tight to the specific AxisMessages are correctly populated. There are 72 test cases testing all Axis2 supported MEPs with both SOAP 1.1 and SOAP 1.2 bindings.
Note: Please note how within 'MessageExchangePatternsTest' there are static maps and utility methods that aim to simplify the retrieval of the right MEP/message direction/etc. depending on the value of 'isServerSide'. Something similar could be done for non-test code (i.e. 1) creating a class encapsulating all this logic 2) adding protected methods to 'WSDLToAxisServiceBuilder' that reads the 'isServerSide' flag from its instance properties and use those convenience methods to retrieve the proper message/direction/etc 3) refactoring the code in 'WSDL11ToAxisServiceBuilder' and 'WSDL20ToAxisServiceBuilder' that deals with the 'isServerSide' flag directly).
> WSDL11ToAxisServiceBuilder: Population of AxisBindingMessage and AxisMessages objects is inconsistent when the isServerSide flag is set to false
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: AXIS2-4090
> URL: https://issues.apache.org/jira/browse/AXIS2-4090
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: kernel
> Affects Versions: 1.4, nightly
> Environment: Windows XP. 4GB RAM Intel Xeon dual-core @2.83Ghz
> Reporter: Antonio Andrade
> Attachments: AXIS2-4090-JUnitTests.patch, AXIS2-4090.patch
>
> Original Estimate: 6h
> Remaining Estimate: 6h
>
> Observed Behavior:
> Within the 'populateBinding' method, both the Message Exchange Pattern of the operation -axisOperation.getMessageExchangePattern()- and the message labels -WSDLConstants.MESSAGE_LABEL_XX_VALUE- depend on the 'isServerSide' flag but this dependency is ignored when the AxisBindingMessage and AxisMessage objects are being populated. This can be seen whenever the 'isServerSide' flag is set to 'false'.
> Expected Behavior:
> The value of both the operation's MEP and message labels should be retrieved taking into consideration the 'isServerSide' flag.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Issue Comment Edited: (AXIS2-4090)
WSDL11ToAxisServiceBuilder: Population of AxisBindingMessage and
AxisMessages objects is inconsistent when the isServerSide flag is set to
false
Posted by "Antonio Andrade (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640216#action_12640216 ]
aandrade edited comment on AXIS2-4090 at 10/16/08 12:21 PM:
-------------------------------------------------------------------
Submitting patch for Review:
Setting the value of both the operation MEP and message labels depending of the 'isServerSide' flag value.
Other: I think that the 'isServerSide' flag usage should be reviewed and a general refactoring should be considered. i.e. There should probably be methods defined in the WSDLToAxisServiceBuilder that deal with the retrieval of isServerSide-sensitive information (messages based on directions, labels, etc) in a more consistent way. The usage of this flag has caused a lot of duplication of code
was (Author: aandrade):
Setting the value of both the operation MEP and message labels depending of the 'isServerSide' flag value.
Other: I think that the 'isServerSide' flag usage should be reviewed and a general refactoring should be considered. i.e. There should probably be methods defined in the WSDLToAxisServiceBuilder that deal with the retrieval of isServerSide-sensitive information (messages based on directions, labels, etc) in a more consistent way. The usage of this flag has caused a lot of duplication of code
> WSDL11ToAxisServiceBuilder: Population of AxisBindingMessage and AxisMessages objects is inconsistent when the isServerSide flag is set to false
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: AXIS2-4090
> URL: https://issues.apache.org/jira/browse/AXIS2-4090
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: kernel
> Affects Versions: 1.4, nightly
> Environment: Windows XP. 4GB RAM Intel Xeon dual-core @2.83Ghz
> Reporter: Antonio Andrade
> Attachments: AXIS2-4090.patch
>
> Original Estimate: 6h
> Remaining Estimate: 6h
>
> Observed Behavior:
> Within the 'populateBinding' method, both the Message Exchange Pattern of the operation -axisOperation.getMessageExchangePattern()- and the message labels -WSDLConstants.MESSAGE_LABEL_XX_VALUE- depend on the 'isServerSide' flag but this dependency is ignored when the AxisBindingMessage and AxisMessage objects are being populated. This can be seen whenever the 'isServerSide' flag is set to 'false'.
> Expected Behavior:
> The value of both the operation's MEP and message labels should be retrieved taking into consideration the 'isServerSide' flag.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-4090) WSDL11ToAxisServiceBuilder: Population
of AxisBindingMessage and AxisMessages objects is inconsistent when the
isServerSide flag is set to false
Posted by "Antonio Andrade (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Andrade updated AXIS2-4090:
-----------------------------------
Attachment: AXIS2-4090.patch
Setting the value of both the operation MEP and message labels depending of the 'isServerSide' flag value.
Other: I think that the 'isServerSide' flag usage should be reviewed and a general refactoring should be considered. i.e. There should probably be methods defined in the WSDLToAxisServiceBuilder that deal with the retrieval of isServerSide-sensitive information (messages based on directions, labels, etc) in a more consistent way. The usage of this flag has caused a lot of duplication of code
> WSDL11ToAxisServiceBuilder: Population of AxisBindingMessage and AxisMessages objects is inconsistent when the isServerSide flag is set to false
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: AXIS2-4090
> URL: https://issues.apache.org/jira/browse/AXIS2-4090
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: kernel
> Affects Versions: 1.4, nightly
> Environment: Windows XP. 4GB RAM Intel Xeon dual-core @2.83Ghz
> Reporter: Antonio Andrade
> Attachments: AXIS2-4090.patch
>
> Original Estimate: 6h
> Remaining Estimate: 6h
>
> Observed Behavior:
> Within the 'populateBinding' method, both the Message Exchange Pattern of the operation -axisOperation.getMessageExchangePattern()- and the message labels -WSDLConstants.MESSAGE_LABEL_XX_VALUE- depend on the 'isServerSide' flag but this dependency is ignored when the AxisBindingMessage and AxisMessage objects are being populated. This can be seen whenever the 'isServerSide' flag is set to 'false'.
> Expected Behavior:
> The value of both the operation's MEP and message labels should be retrieved taking into consideration the 'isServerSide' flag.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-4090) WSDL11ToAxisServiceBuilder: Population
of AxisBindingMessage and AxisMessages objects is inconsistent when the
isServerSide flag is set to false
Posted by "Antonio Andrade (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Andrade updated AXIS2-4090:
-----------------------------------
Attachment: JUnit Tests - After.jpg
Results after the patch has been applied
> WSDL11ToAxisServiceBuilder: Population of AxisBindingMessage and AxisMessages objects is inconsistent when the isServerSide flag is set to false
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: AXIS2-4090
> URL: https://issues.apache.org/jira/browse/AXIS2-4090
> Project: Axis 2.0 (Axis2)
> Issue Type: Bug
> Components: kernel
> Affects Versions: 1.4, nightly
> Environment: Windows XP. 4GB RAM Intel Xeon dual-core @2.83Ghz
> Reporter: Antonio Andrade
> Attachments: AXIS2-4090-JUnitTests.patch, AXIS2-4090.patch, JUnit Tests - After.jpg, JUnit Tests - Before.jpg
>
> Original Estimate: 6h
> Remaining Estimate: 6h
>
> Observed Behavior:
> Within the 'populateBinding' method, both the Message Exchange Pattern of the operation -axisOperation.getMessageExchangePattern()- and the message labels -WSDLConstants.MESSAGE_LABEL_XX_VALUE- depend on the 'isServerSide' flag but this dependency is ignored when the AxisBindingMessage and AxisMessage objects are being populated. This can be seen whenever the 'isServerSide' flag is set to 'false'.
> Expected Behavior:
> The value of both the operation's MEP and message labels should be retrieved taking into consideration the 'isServerSide' flag.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org