[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2964: [NETBEANS-5693] Assure that debugger session finishes when native image application exits.

[GitBox <gi...@apache.org>]

JaroslavTulach commented on a change in pull request #2964:
URL: https://github.com/apache/netbeans/pull/2964#discussion_r635970171



##########
File path: java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/debugging/launch/NbLaunchDelegate.java
##########
@@ -200,30 +201,43 @@ public void progressHandleCreated(ProgressOperationEvent e) {
             List<String> args = argsToStringList(launchArguments.get("args"));
             if (debug) {
                 requestProcessor.post(() -> {
-                    Lookups.executeWith(launchCtx, () -> {
+                    ActionProgress debugProgress = ActionProgress.start(launchCtx);
+                    // Add session's lookup, it may override dialog displayer, etc.
+                    Lookups.executeWith(new ProxyLookup(launchCtx, context.getLspSession().getLookup()), () -> {
                         String miDebugger = (String) launchArguments.get("miDebugger");
-                        startNativeDebug(nativeImageFile, args, miDebugger, context, executionDescriptor, launchFuture);
+                        startNativeDebug(nativeImageFile, args, miDebugger, context, executionDescriptor, launchFuture, debugProgress);
                     });
                 });
             } else {
+                AtomicReference<Future<Integer>> run = new AtomicReference<>();
                 Lookups.executeWith(launchCtx, () -> {
-                    execNative(nativeImageFile, args, context, executionDescriptor, launchFuture);//, success);
+                    run.set(execNative(nativeImageFile, args, context, executionDescriptor, launchFuture));
+                });
+                new RequestProcessor().post(() -> {
+                    Integer ret;

Review comment:
       This looks like the old, ugly pattern. Since https://github.com/apache/netbeans/pull/2938/files#r635969684 once can get the `exitCode` (or `null`) synchronously as soon as execution is over.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists