You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/13 13:34:46 UTC
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #114: 🔧 Add json schema to validate helm3 values.
tokers commented on a change in pull request #114:
URL: https://github.com/apache/apisix-helm-chart/pull/114#discussion_r668767957
##########
File path: charts/apisix/values.schema.json
##########
@@ -0,0 +1,255 @@
+{
+ "$schema": "http://json-schema.org/schema#",
+ "type": "object",
+ "properties": {
+ "apisix": {
+ "type": "object",
+ "title": "APISIX Setting(s)",
+ "form": true,
+ "properties": {
+ "enabled": {
+ "type": "boolean",
+ "title": "Enable apisix",
+ "description": "Enable or disable Apache APISIX itself",
+ "form": true,
+ "default": true
+ },
+ "replicaCount": {
Review comment:
We should add the `minimum` constraint.
##########
File path: charts/apisix/values.schema.json
##########
@@ -0,0 +1,255 @@
+{
+ "$schema": "http://json-schema.org/schema#",
+ "type": "object",
+ "properties": {
+ "apisix": {
+ "type": "object",
+ "title": "APISIX Setting(s)",
Review comment:
```suggestion
"title": "Apache APISIX Setting(s)",
```
##########
File path: charts/apisix/values.schema.json
##########
@@ -0,0 +1,255 @@
+{
+ "$schema": "http://json-schema.org/schema#",
+ "type": "object",
+ "properties": {
+ "apisix": {
+ "type": "object",
+ "title": "APISIX Setting(s)",
+ "form": true,
+ "properties": {
+ "enabled": {
+ "type": "boolean",
+ "title": "Enable apisix",
+ "description": "Enable or disable Apache APISIX itself",
+ "form": true,
+ "default": true
+ },
+ "replicaCount": {
+ "type": "integer",
+ "title": "Number of replicas",
+ "form": true,
+ "default": 1,
+ "hidden": {
+ "condition": false,
+ "value": "apisix.enabled"
+ }
+ }
+ }
+ },
+ "etcd": {
+ "type": "object",
+ "title": "Etcd configuration",
+ "form": true,
+ "properties": {
+ "enabled": {
+ "type": "boolean",
+ "title": "Enable etcd",
+ "description": "install etcd(v3) by default, set false if do not want to install etcd(v3) together",
+ "form": true,
+ "default": true
+ },
+ "replicaCount": {
Review comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org