You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "spuru9 (via GitHub)" <gi...@apache.org> on 2026/10/21 16:06:07 UTC

[PR] [BP-1.20][FLINK-41053][test] Backport MAX_RETAINED_CHECKPOINTS fix to UnalignedCheckpointRescaleWithMixedExchangesITCase [flink]

spuru9 opened a new pull request, #29552:
URL: https://github.com/apache/flink/pull/29552

   ## What is the purpose of the change
   
   `UnalignedCheckpointRescaleWithMixedExchangesITCase.testRescaleFromUnalignedCheckpoint` still fails on release-1.20 with `Cannot find checkpoint or savepoint file/directory` for `chk-1` (FLINK-41053).
   
   The test sets `MAX_RETAINED_CHECKPOINTS` to 50 in the job config, but the completed checkpoint store reads it from the cluster config (`SchedulerUtils` -> `getMaximumNumberOfRetainedCheckpoints(jobMasterConfiguration)`), so only 1 checkpoint is retained. If the next checkpoint completes between picking the path and cancelling the first job, the picked checkpoint is subsumed and deleted before the second job restores from it.
   
   This backports 17581beed0c (FLINK-39140), which is on master and release-2.3, where the test has no hits.
   
   ## Brief change log
   
     - Cherry-pick of 17581beed0c: set `MAX_RETAINED_CHECKPOINTS` on the MiniCluster config instead of the per-job config
   
   ## Verifying this change
   
   This change is a test-only fix covered by the ITCase itself. The test passes locally with the change. The `chk-1` failure did not reproduce locally on the baseline (25 sequential runs, 64 runs under CPU load), so confirmation has to come from the release-1.20 nightlies.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code (Opus 5.5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [BP-1.20][FLINK-41053][test] Backport MAX_RETAINED_CHECKPOINTS fix to UnalignedCheckpointRescaleWithMixedExchangesITCase [flink]

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser merged PR #29552:
URL: https://github.com/apache/flink/pull/29552


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [BP-1.20][FLINK-41053][test] Backport MAX_RETAINED_CHECKPOINTS fix to UnalignedCheckpointRescaleWithMixedExchangesITCase [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #29552:
URL: https://github.com/apache/flink/pull/29552#issuecomment-6320483691

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8df26e72261130816c0dfb4c79242332eb207488",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8df26e72261130816c0dfb4c79242332eb207488",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8df26e72261130816c0dfb4c79242332eb207488 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org