[jira] [Commented] (MYFACES-4521) faces.js handing of params attribute missing in the old jsf.js codebase

["Volodymyr Siedlecki (Jira)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644488#comment-17644488 ] 

Volodymyr Siedlecki commented on MYFACES-4521:
----------------------------------------------

Hi, I tested this out, but I don't see the expected behavior (as per the TCK).

I see the options[execute] is overridden here: https://github.com/apache/myfaces/blob/0b3b8cb026102a321298f82b511f693ea88f78f9/api/src/main/javascript/META-INF/resources/myfaces/api/faces.js#L479-L481 

The execute:ParamValue is never sent in the request. 

> faces.js handing of params attribute missing in the old jsf.js codebase
> -----------------------------------------------------------------------
>
>                 Key: MYFACES-4521
>                 URL: https://issues.apache.org/jira/browse/MYFACES-4521
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 2.2.15, 2.3-next-M7, 4.0.0-RC2
>            Reporter: Werner Punz
>            Assignee: Werner Punz
>            Priority: Major
>             Fix For: 2.3-next-M8, 4.0.0-RC3
>
>
> In reference to https://issues.apache.org/jira/browse/MYFACES-4040
> We have had a spec deviation from the spec since jsf 2.0
> apparently request parameters must be passed in the options associative array under the key params (see link above where I documented it)
> This already has been fixed in the new typescript codebase but the fix is missing from the old javascript codebase. 
> The fix is fairly straight forward.
> For now we will keep the old behavior, to keep legacy code intact, but the f:params renderer also must be adapted accordingly.
> Either I will do that or someone else.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)