You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zjureel <gi...@git.apache.org> on 2017/03/16 04:56:02 UTC
[GitHub] flink pull request #3552: [FLINK-5978] Fix JM WebFrontend address ConfigOpti...
GitHub user zjureel opened a pull request:
https://github.com/apache/flink/pull/3552
[FLINK-5978] Fix JM WebFrontend address ConfigOption is defined in Co\u2026
\u2026nfigConstants
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjureel/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3552.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3552
----
commit 6a611f5b1649af8f40c97014267a681cec1c0df9
Author: mengji.fy <me...@taobao.com>
Date: 2017-03-16T04:53:03Z
[FLINK-5978] Fix JM WebFrontend address ConfigOption is defined in ConfigConstants
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3552: [FLINK-5978] Fix JM WebFrontend address ConfigOption is d...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3552
Looking into #2680 that added this change, it was meant to be followed up on and move all web configuration to a new class. Could we do this here and not only a single one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3552: [FLINK-5978] Fix JM WebFrontend address ConfigOption is d...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3552
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3552: [FLINK-5978] Fix JM WebFrontend address ConfigOpti...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3552
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---