[GitHub] [dubbo-go-pixiu] baerwang commented on a diff in pull request #459: feat:Provide unified metrics calculation and reporting implementation

[GitBox <gi...@apache.org>]

baerwang commented on code in PR #459:
URL: https://github.com/apache/dubbo-go-pixiu/pull/459#discussion_r935375279


##########
pkg/metrics/global/global.go:
##########
@@ -0,0 +1,11 @@
+package global
+
+//主要完成一些公共使用类代码的封装以一些全局关键字的定义。
+import ()
+
+const (
+	// Exporter Namespace.
+	// Namespace将会经常被scrape和collector甚至main调用

Review Comment:
   change english and add field meaning



##########
pkg/metrics/collector/cluster_health.go:
##########
@@ -0,0 +1,336 @@
+package collector
+
+import (
+	"log"
+
+	"encoding/json"
+	"fmt"
+	"io/ioutil"
+	"net/http"
+	"net/url"
+
+	"path"
+
+	"github.com/apache/dubbo-go-pixiu/pkg/metrics/global"
+	"github.com/prometheus/client_golang/prometheus"
+	"github.com/prometheus/client_golang/prometheus/promhttp"

Review Comment:
   split import style



##########
pkg/metrics/collector/api_health.go:
##########
@@ -0,0 +1,182 @@
+package collector
+
+import (
+	"encoding/json"
+	"fmt"
+	"github.com/apache/dubbo-go-pixiu/pkg/metrics/global"
+	"github.com/prometheus/client_golang/prometheus"

Review Comment:
   split import style



##########
pkg/metrics/collector/api_health.go:
##########
@@ -0,0 +1,182 @@
+package collector
+
+import (
+	"encoding/json"
+	"fmt"
+	"github.com/apache/dubbo-go-pixiu/pkg/metrics/global"
+	"github.com/prometheus/client_golang/prometheus"
+	"io/ioutil"
+	"log"
+	"net/http"
+	"net/url"
+	"path"
+)
+
+//很多api的状态

Review Comment:
   change english



##########
pkg/metrics/global/global.go:
##########
@@ -0,0 +1,11 @@
+package global
+
+//主要完成一些公共使用类代码的封装以一些全局关键字的定义。
+import ()

Review Comment:
   del and change english



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org