You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "waitinfuture (via GitHub)" <gi...@apache.org> on 2023/07/20 13:21:10 UTC

[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1706: [CELEBORN-788] Fixed the issue of submitRetryPushData using the old loc for revive when receiving consecutive hard_split.

waitinfuture commented on PR #1706:
URL: https://github.com/apache/incubator-celeborn/pull/1706#issuecomment-1643916877

   I reviewed the code logic for push merged data, and I think push merged data does not have similar issue, because newer DataBatches do use the new location.
   ```
   } else if (request.reviveStatus == StatusCode.SUCCESS.getValue()) {
     PartitionLocation newLoc = reducePartitionMap.get(shuffleId).get(request.partitionId);
     DataBatches newDataBatches =
         newDataBatchesMap.computeIfAbsent(genAddressPair(newLoc), (s) -> new DataBatches());
     newDataBatches.addDataBatch(newLoc, batch.batchId, batch.body);
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org