[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1353: MINIFICPP-1863 fixing duplicate entry in PutGCSObject::properties

[GitBox <gi...@apache.org>]

martinzink commented on code in PR #1353:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1353#discussion_r901527226


##########
extensions/gcp/processors/PutGCSObject.h:
##########
@@ -58,7 +58,6 @@ class PutGCSObject : public GCSProcessor {
     return utils::array_cat(GCSProcessor::properties(), std::array{
       Bucket,
       Key,
-      NumberOfRetries,

Review Comment:
   This is included in [GCSProcessor::properties](https://github.com/apache/nifi-minifi-cpp/blob/main/extensions/gcp/processors/GCSProcessor.h#L46)



##########
extensions/gcp/processors/PutGCSObject.h:
##########
@@ -58,7 +58,6 @@ class PutGCSObject : public GCSProcessor {
     return utils::array_cat(GCSProcessor::properties(), std::array{
       Bucket,
       Key,
-      NumberOfRetries,

Review Comment:
   This is already included in [GCSProcessor::properties](https://github.com/apache/nifi-minifi-cpp/blob/main/extensions/gcp/processors/GCSProcessor.h#L46)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org