You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by holdenk <gi...@git.apache.org> on 2017/01/26 00:20:53 UTC

[GitHub] spark pull request #16536: [SPARK-19163][PYTHON][SQL] Delay _judf initializa...

Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16536#discussion_r97907507
  
    --- Diff: python/pyspark/sql/functions.py ---
    @@ -1826,19 +1826,27 @@ class UserDefinedFunction(object):
         def __init__(self, func, returnType, name=None):
             self.func = func
             self.returnType = returnType
    -        self._judf = self._create_judf(name)
    -
    -    def _create_judf(self, name):
    +        self._judf_placeholder = None
    --- End diff --
    
    Maybe add a comment explaining the purposes of this, just for future readers of the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org